Repository navigation
tests, ci: honor Windows VTMP and remove temporary diagnostics - #32197
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#32194 merged while its last fixture adjustment and diagnostic cleanup were being finalized. This follow-up contains only those two remaining changes.
Changes
os.vtmp_dir()with the shortenedvtc_...directory name, so they honor the shortVTMPalready configured by Windows CI. The earlier version usedos.temp_dir(), ignoring that setting and placing nested MSVC output beneath the longer user temporary directory.ci_regressions.ymldiagnostic workflow, preserving the repository's existing long-term CI trigger policy.The diagnostic run passed the new generic regression with TCC/MSVC, all six assignment-review tests, and the original manifest-staging case. Two other tool-cache cases failed while MSVC generated
atomic_ops.cintermediate output (C1083, invalid argument). RespectingVTMPcorrects the fixture's temp-root selection; native confirmation of those two cases remains outstanding.The HTTP/2 diagnostic's trace option exposed an unrelated module-initialization-retention problem and did not reproduce the original stall. No tracing or HTTP runtime behavior is changed here.
Validation
Further tests were explicitly skipped as requested. The one-line VTMP adjustment has not been rerun. Completed validation and remaining findings are recorded in #32194 and the companion VTL PR.