Repository navigation
transform, tests: fix VTL, MSan and Windows CI regressions - #32194
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on aebadc37 finished with 138 successful, 22 failed, 26 cancelled, and 18 skipped checks. This branch starts from master
e957563bband fixes the remaining reproducible VTL/compiler, MemorySanitizer, and Windows fixture problems.Changes
datasets__CollatedBatch_f64before its result wrapper and fixes the eight VTL example-build failures. A regression covers callback parameters, result payloads, and option payloads without invoking the callbacks.libEGLand failed MemorySanitizer insidescandir64. Initialize a recording-onlyGpuSurface, retain every assertion, and explicitly verify the restored element is valid.VTMPis in follow-up tests, ci: honor Windows VTMP and remove temporary diagnostics #32197.No tests are removed or disabled, and no sanitizer suppression is added. This PR merged before diagnostic cleanup was finalized. Follow-up #32197 removes the temporary Windows workflow and preserves the repository's long-term CI trigger policy.
The external VTL rounding failures and its retired macOS runner are addressed in vlang/vtl#833.
Completed validation
./v self.nn_cifar10_safeandnn_cifar10_tiny, compile in pure and-d cblasmodes with-no-parallel -nocache, using the failed run's exact VTL/VSL revisions and with compatibility fallback disabled.recover_no_skip_unused_test.v.c_compiler_flags_test.v,object_static_local_test.v, andnaming_test.v).vetinvocations pass in about six seconds using an optimized musl-hosted V compiler, so the original musl cache-lock timeout was not reproduced.Remaining CI findings / validation limits
Further local test execution was stopped as requested. This PR does not claim a green full master matrix.
atomic_ops.cintermediate output. Follow-up tests, ci: honor Windows VTMP and remove temporary diagnostics #32197 makes fixtures honor the short configuredVTMP, which this version ignored; that adjustment has not been rerun.Already fixed on master
The base includes the Linux
pipe2fix (#32175), coreutils symbol fix (#32177), Windows checker-print and compiler-selection fixes (#32181, #32182), and multi-object pipe-helper linkage fix (#32186). The old C2Vs_sfx/Booleanerrors occur after the primarypipe2failure triggers the obsolete compiler fallback. These existing fixes are not duplicated here.