Repository navigation
docs(cic): correct UNFAOPostProcessorManager ADR-008 + env-var claims (#17) - #66
Merged
Merged
Conversation
…#17, C-19) The manager CIC over-claimed two guarantees the code does not fully meet: - §3 "all structural failures are logged and raised (ADR-008)" -> qualified to "partially": _validate gates + the S0-S6 guards comply, but 3 raises in unfao.py (missing ensemble, missing loa, datasets-None in _save) still lack a preceding logger.error (C-19 / #13). - §4 "assumptions not met must cause failure" -> noted the known gap: Appwrite env vars are read via os.getenv() with no startup validation, so a missing var becomes None and is passed to AppwriteConfig unchecked (#11). Resolves the two remaining #17 discrepancies; the other four were mooted by the PriogridCountryMapper CIC deletion (C-39). Docs-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two remaining discrepancies in #17 (CIC accuracy). The other four were mooted by the PriogridCountryMapper CIC deletion (C-39).
_validate+ the S0–S6 guards comply, but 3 raises inunfao.pystill lack a precedinglogger.error(C-19 / ADR-008 compliance: add log-before-raise to remaining raises (C-19) #13).os.getenv()returnsNonefor a missing var and passes it toAppwriteConfigunchecked (Add timeout to Appwrite download and upload operations (C-13) #11).Docs-only. ruff clean; full suite passes (the one local failure,
test_datafactory_deploy_readiness, is an unrelated CI-skipped stub that flipped because datafactory advanced to 1.5.0-dev — not touched here).🤖 Generated with Claude Code