Update CICs to match actual code behavior (Cluster F)

[Polichinel]

Context

The falsification campaign (Claims 1.1, 1.2) found that both CICs describe aspirational behavior, not actual behavior. 5 specific discrepancies:

PriogridCountryMapper CIC

1. §3 cache guarantee: Says "cache mode does not affect results." Reality: C-05 documents 6 methods that crash in disk mode. Needs caveat.
2. §5 return types: Says find_country_for_gid returns 4 keys. Reality: returns ~170 keys (all Natural Earth columns dumped). Needs full documentation or code fix.
3. §6 log level: Says intersection failures logged as "WARNING." Reality: 7 sites use logger.debug. Needs to say DEBUG.
4. §5 admin1 return: Lists 4 keys. Reality: also returns gaul0_code, gaul0_name, continent, disp_en. Needs complete listing.

UNFAOPostProcessorManager CIC

5. §3 ADR-008 compliance: Claims "all structural failures are logged and raised." Reality: 3 of 7 raises in unfao.py lack preceding logger.error (C-19).
6. §6 env var boundary: Claims missing env vars "must cause failure." Reality: os.getenv() returns None and passes it to AppwriteConfig without validation.

Requirements

Update both CICs to describe what the code DOES, not what we wish it did. Specifically:

• Add C-05 caveat to cache guarantee
• Document actual return key sets (or note "additional shapefile columns included")
• Change "WARNING" to "DEBUG" in §6
• Qualify ADR-008 claim as "partially compliant" with cross-ref to C-19
• Qualify env var boundary claim with cross-ref to the validation gap

Risk Register

Cluster F (documentation accuracy risk, not code risk).
Campaign: Claims 1.1 (FALSIFIED 3H/1S), 1.2 (FALSIFIED 2H).

[Polichinel]

Status vs current development (2026-06-27): 4 of 6 discrepancies moot; 2 remain.

PriogridCountryMapper CIC — discrepancies 1–4 are MOOT: that CIC was deleted along with the mapper (C-39). docs/CICs/ now holds only GaulLookupEnricher.md, UNFAOPostProcessorManager.md, README.md, cic_template.md.

UNFAOPostProcessorManager CIC — discrepancies 5–6 still stand:

• §3 (:39) still claims "Guarantees that all structural failures are logged and raised (ADR-008)" — but 3 raises lack log-before (see ADR-008 compliance: add log-before-raise to remaining raises (C-19) #13). Needs a "partially compliant" qualifier + cross-ref to C-19.
• §5/§6 (:52) still claims unmet assumptions "must cause failure" — but os.getenv() returns None and is passed to AppwriteConfig unvalidated. Needs the env-var-validation gap noted.

Note: §6 (failure modes) and §10 (test alignment) were refreshed in #64 to document the new S0–S6 guards; the two items above were not touched. Also additive: a new GaulLookupEnricher.md CIC now exists (worth a quick accuracy pass). Scope is now 2 edits to the manager CIC (+ optional enricher-CIC check), not 6.

[Polichinel]

Done — closing. The two remaining discrepancies (manager CIC §3 ADR-008 over-claim → qualified; §4 env-var validation gap → noted) were fixed in #66; the four PriogridCountryMapper-CIC discrepancies were mooted by that CIC's deletion (C-39). The base-docs audit (2026-06-28) confirmed both current CICs are accurate, and the CIC §3 was further updated when C-19 resolved (#68 / tech-debt pass). No remaining drift.