Skip to content

chore(naming): align Layer-1 target fixture to lr_ged_sb (#49) #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Polichinel merged 1 commit into from
Jun 24, 2026
Merged

chore(naming): align Layer-1 target fixture to lr_ged_sb (#49) #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_views_frames_conformance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def _frame(months=(100, 101), gids=(1, 2, 3)):
return pd.DataFrame(
{
"pred_ln_sb_best": rng.gamma(2.0, 1.0, size=len(rows)),
"ged_sb_best": rng.integers(0, 50, size=len(rows)),
"lr_ged_sb": rng.integers(0, 50, size=len(rows)),
},
index=idx,
)
Expand Down Expand Up @@ -72,12 +72,12 @@ def test_values_come_from_the_named_column(self):

class TestTargetFrameConformance:
def test_satisfies_frame_contract(self):
tf = to_target_frame(_frame(), "ged_sb_best")
tf = to_target_frame(_frame(), "lr_ged_sb")
assert_frame_contract(tf)

def test_observed_actuals_shape(self):
df = _frame()
tf = to_target_frame(df, "ged_sb_best")
tf = to_target_frame(df, "lr_ged_sb")
assert isinstance(tf, TargetFrame)
assert tf.n_rows == len(df)
assert tf.values.shape == (len(df), 1)
Expand Down
Loading