Repository navigation
chore(naming): align Layer-1 target fixture to lr_ged_sb (#49) - #50
Merged
Merged
Conversation
…49) #49 described the target as `lr_*_best`, which does not exist in this repo. The real Layer-1 target-name straggler is `ged_sb_best` (3x in test_views_frames_conformance.py), which the canonical (views-models#151) and this repo's own ADR-011 doc map to `lr_ged_sb`. Rename those 3; the Layer-2 delivery column `pred_ln_sb_best` is left untouched (explicitly out of scope). Synthetic test label only — no logic change; suite green. Closes #49. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49.
Corrected scope: #49 said to rename
lr_*_best(~10 occurrences) — but that pattern does not exist in this repo (verified across all tracked files incl. the.npzfixture keys). The real Layer-1 target-name straggler isged_sb_best(3× intests/test_views_frames_conformance.py), which both the canonical (views-models#151) and this repo'sdocs/ADR-011_implementation_assessment.mdmap tolr_ged_sb.ged_sb_best→lr_ged_sb(the target/actuals column).pred_ln_sb_best(explicitly out of scope per chore(naming): align Layer-1 target fixtures to lr_ged_* (Layer-2 pred_ln_* excluded) #49 / S3 — Collapse the two extraction seams into one #151).Synthetic test label only — no logic change.
ruffclean, 101 passed / 43 xfailed.🤖 Generated with Claude Code