Repository navigation
chore(register): review-rr strategic curation + mechanical integrity guard - #140
Merged
Polichinel merged 1 commit intoJul 30, 2026
Merged
Conversation
…guard The register had drifted four days behind two events — run-0's delivery (2026-07-27) and the þing-01 verdict (2026-07-28) — and its own structure had drifted with it. Structural: header said 25 open / 30 resolved; the file held 27 / 28. Root cause was C-19 and C-45 carrying RESOLVED bodies while still filed under Open. Both relocated, along with C-08 (→ views-datafactory), C-37/C-38 (→ views-frames), C-42 (settled its own internal contradiction) and C-32 (measured, not deferred). C-34 merged into C-30 as a forwarding stub. Eight stale unfao.py line ranges refreshed against the current 636-line manager; foreign-register IDs (C-161, C-146, C-71) namespaced to the repos that own them. Calibration: C-30 tier 1→2 (run-0 exercised the coverage guard live at 64,742 cells), C-24 tier 2→3 (entry's own conclusion is that it is not this repo's to fix). C-26 held at tier 1 with an open question logged for the pipeline-core seat — whether get_feature_frame inherits the fillna(0.0) could not be verified from here. Four expired triggers, five symptomatic ones and one circular one rewritten; C-43's now says plainly that it has fired. Clusters A-F indexed only deleted mapper-era code and covered no open entry; collapsed to a historical stub and replaced with G (inherited pipeline-core surface), H (go-global debt, discharged unevenly by run-0), I (governance-artifact drift) and J (delivery aftercare). Three entries registered from the blind-spot analysis: - C-56 the run-0 OOM incident chain (23.8 GB kill → 5.6 GB frame-native), which the closeout plan required and never got, plus the live memory budget it leaves - C-57 PLATFORM-001 registry drift — referenced by URL, so nothing local can diff it - C-58 wrong Appwrite coordinate auto-provisions instead of raising, on both client lineages (þing-01 D5; the finding that widened the verdict's D8 trigger) tests/test_register_integrity.py makes this class self-detecting, the same way test_falsify_adr013_*.py did for the wire contract: counts match sections, no closed entry under Open, section order, unique IDs, required field rows, and references that either resolve here or name their owning repo. Mutation-checked against all three historical bugs — each is caught by its own guard. appwrite_cache/ gitignored: downloaded partner-store objects were untracked AND unignored, one `git add -A` away from being committed ahead of the first public release (#125). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strategic
/review-rrpass onreports/technical_risk_register.md, plus the guard that stops its findings recurring.Why
The register was four days behind two events — run-0's delivery (2026-07-27) and the þing-01 verdict (2026-07-28) — and between them they fired or expired the triggers on eight open entries. Four entries still read "we'll verify at the global run" for a global run that had already happened.
Structural
Root cause of the mismatch: C-19 and C-45 carried RESOLVED bodies but were never physically moved out of
## Open Concerns. Both re-verified in code before relocating.Also relocated/resolved: C-08 (→ views-datafactory), C-37/C-38 (→ views-frames — code left in #62), C-42 (settled the direct internal contradiction between its own two closing paragraphs), C-32 (measured, not deferred). C-34 merged into C-30 as a forwarding stub so cross-refs still resolve.
Eight stale
unfao.pyline ranges refreshed (the manager grew 273 → 636 lines);C-161/C-146/C-71namespaced to the registers that own them.Calibration
get_feature_frame(the path run-0 actually used) inherits thefillna(0.0)could not be verified from here, since pipeline-core is deliberately absent from test environments. Needs the pipeline-core seat.12 triggers rewritten — 4 expired, 5 symptomatic, 1 circular, 1 compound. C-43's now says plainly that it has fired.
The finding that matters
Run-0 discharged the availability half of the go-global debt (path runs, 5.6 GB peak, coverage proven) and left C-43 — the correctness half — standing alone and un-gated, with unverified enrichment values now in FAO's store. Proving the path runs at scale was never what C-43 asked for. Its forward-check (sample
land_gaulassignments against the datafactory GAUL parquet) is cheap and folds into #131 q1.Clusters
A–F indexed only deleted mapper-era code and covered no open entry. Collapsed to a historical stub; replaced with G (inherited pipeline-core surface), H (go-global debt), I (governance-artifact drift), J (delivery aftercare) — covering 19 of 21 live entries.
Three entries registered
appwrite_env.pyagainstcoordinate_registry.toml. Two changes are already anticipated (legacy key retirement, second store).The guard
tests/test_register_integrity.py(8 tests, stdlib only) — counts match sections, no closed entry under Open, section order, unique IDs, required field rows, references that resolve here or name their owning repo.Mutation-checked: each of the three historical bugs was re-introduced and caught by its own guard. Same pattern this repo already used for ADR-013 (
test_falsify_adr013_*.py) and þing-01 (test_env_declaration.py).Also
appwrite_cache/gitignored — downloaded partner-store objects (production_forecasts/,unfao_bucket/,cache_metadata.json) were untracked and unignored, onegit add -Afrom being committed ahead of the first public release (#125).Verification
ruffclean.278 passed, 41 xfailed. The 5 failures are the known local pyarrow byte-parity tests (local 23.0.1 vs pinned 16.1.0) — CI authoritative.No source code touched — register, one new test, one gitignore line.
🤖 Generated with Claude Code