Skip to content

fix: update submodule references for vnecmake, vnecommon, and vnelogging - #28

Merged
ajeetsinghyadav merged 1 commit into
mainfrom
VNE_TEMPLATE_SYNC_LIBs
May 17, 2026
Merged

ajeetsinghyadav merged 1 commit into
mainfrom
VNE_TEMPLATE_SYNC_LIBs

Conversation

@ajeetsinghyadav

@ajeetsinghyadav ajeetsinghyadav commented May 17, 2026 •

Copy link
Copy Markdown
Member

Description

Release notes: Use a Conventional Commits–style PR title (e.g. feat: add X, fix: resolve Y, docs: update Z) so release-please can include this change in the changelog. If you squash-merge, use the PR title as the commit message.

Checklist

  • Project builds (e.g. cmake -B build/shared and cmake --build build/shared, or platform script with -l shared/-l static).
  • Tests pass (e.g. ctest --test-dir build/shared or script -a test).
  • Code is formatted (e.g. run clang-format as configured for this repo); CI clang-format will check.
  • Docs updated if you changed behavior or public API.

Additional notes

Summary by CodeRabbit

  • Chores
    • Updated internal build system and dependency references to latest versions.

Review Change Stack

Copilot AI review requested due to automatic review settings May 17, 2026 17:34
@ajeetsinghyadav ajeetsinghyadav self-assigned this May 17, 2026
@coderabbitai

coderabbitai Bot commented May 17, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc5cfc14-99c2-444b-aee8-98467e1d7370

📥 Commits

Reviewing files that changed from the base of the PR and between 0807348 and c87e7c9.

📒 Files selected for processing (3)
  • cmake/vnecmake
  • deps/internal/vnecommon
  • deps/internal/vnelogging

📝 Walkthrough

Walkthrough

This PR updates three git submodule references to new commit hashes: cmake/vnecmake build tooling, deps/internal/vnecommon shared utilities, and deps/internal/vnelogging logging framework. No application code or exported interfaces are modified.

Changes

Dependency Updates

Layer / File(s) Summary
Submodule commit pointers
cmake/vnecmake, deps/internal/vnecommon, deps/internal/vnelogging
Three submodule references are pinned to new commits: cmake build tools, shared utility library, and logging framework.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Three little pins, all updated today,
Build tools and commons hop forth on their way,
Logging flows fresh from the upstream ahead—
Dependencies dance, our templates well-fed!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating submodule references for three dependencies (vnecmake, vnecommon, and vnelogging), which is exactly what the changeset accomplishes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch VNE_TEMPLATE_SYNC_LIBs

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates internal dependency submodule references for VertexNova build/common/logging components. Biggest risk is that the actual submodule code changes are outside the checked-out review context, so they require human verification against the referenced commits.

Changes:

  • Updates vnecmake submodule reference.
  • Updates vnecommon submodule reference.
  • Updates vnelogging submodule reference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
cmake/vnecmake Updates the CMake modules submodule pointer.
deps/internal/vnecommon Updates the internal common utilities submodule pointer.
deps/internal/vnelogging Updates the internal logging submodule pointer.

@ajeetsinghyadav
ajeetsinghyadav merged commit 1f591f1 into main May 17, 2026
25 checks passed
@ajeetsinghyadav
ajeetsinghyadav deleted the VNE_TEMPLATE_SYNC_LIBs branch May 17, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants