Repository navigation
fix: update submodule references for vnecmake, vnecommon, and vnelogging - #28
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR updates three git submodule references to new commit hashes: ChangesDependency Updates
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates internal dependency submodule references for VertexNova build/common/logging components. Biggest risk is that the actual submodule code changes are outside the checked-out review context, so they require human verification against the referenced commits.
Changes:
- Updates
vnecmakesubmodule reference. - Updates
vnecommonsubmodule reference. - Updates
vneloggingsubmodule reference.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cmake/vnecmake |
Updates the CMake modules submodule pointer. |
deps/internal/vnecommon |
Updates the internal common utilities submodule pointer. |
deps/internal/vnelogging |
Updates the internal logging submodule pointer. |
Description
Release notes: Use a Conventional Commits–style PR title (e.g.
feat: add X,fix: resolve Y,docs: update Z) so release-please can include this change in the changelog. If you squash-merge, use the PR title as the commit message.Checklist
cmake -B build/sharedandcmake --build build/shared, or platform script with-l shared/-l static).ctest --test-dir build/sharedor script-a test).clang-formatas configured for this repo); CI clang-format will check.Additional notes
Summary by CodeRabbit