Repository navigation
fix: update vnelogging submodule reference - #30
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the Changesvnelogging Submodule Pointer Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
- Updates the repository’s pinned
deps/internal/vneloggingsubmodule revision to a newer upstream commit. - Primary risk: submodule bumps can introduce API/behavior changes that aren’t visible in this PR’s diff, so downstream build/test compatibility needs to be confirmed.
Changes:
- Bump
deps/internal/vneloggingsubmodule gitlink to a newer revision.
BLOCKER
- None identified in the repository’s tracked text files for this PR.
MAJOR
- Since the actual code changes live in the
vneloggingsubmodule (not in this repo), please ensure CI (or at least local build + tests) is run against this PR and that the updatedvneloggingrevision is compatible with this template’s current CMake integration (target names, exported configs, options likeBUILD_TESTS/BUILD_EXAMPLES, etc.). If possible, include the new submodule commit SHA (or tag) and a short upstream changelog link in the PR description for traceability.
MINOR
- None.
Description
Release notes: Use a Conventional Commits–style PR title (e.g.
feat: add X,fix: resolve Y,docs: update Z) so release-please can include this change in the changelog. If you squash-merge, use the PR title as the commit message.Checklist
cmake -B build/sharedandcmake --build build/shared, or platform script with-l shared/-l static).ctest --test-dir build/sharedor script-a test).clang-formatas configured for this repo); CI clang-format will check.Additional notes
Summary by CodeRabbit