Skip to content

fix: update vnelogging submodule reference - #30

Merged
ajeetsinghyadav merged 1 commit into
mainfrom
VNE_TEMPLATE_SYNC_LOGGING
May 22, 2026
Merged

ajeetsinghyadav merged 1 commit into
mainfrom
VNE_TEMPLATE_SYNC_LOGGING

Conversation

@ajeetsinghyadav

@ajeetsinghyadav ajeetsinghyadav commented May 22, 2026 •

Copy link
Copy Markdown
Member

Description

Release notes: Use a Conventional Commits–style PR title (e.g. feat: add X, fix: resolve Y, docs: update Z) so release-please can include this change in the changelog. If you squash-merge, use the PR title as the commit message.

Checklist

  • Project builds (e.g. cmake -B build/shared and cmake --build build/shared, or platform script with -l shared/-l static).
  • Tests pass (e.g. ctest --test-dir build/shared or script -a test).
  • Code is formatted (e.g. run clang-format as configured for this repo); CI clang-format will check.
  • Docs updated if you changed behavior or public API.

Additional notes

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest versions

Review Change Stack

Copilot AI review requested due to automatic review settings May 22, 2026 02:45
@ajeetsinghyadav ajeetsinghyadav self-assigned this May 22, 2026
@coderabbitai

coderabbitai Bot commented May 22, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83715c98-1f65-4cb2-a31f-604acf3bbcf1

📥 Commits

Reviewing files that changed from the base of the PR and between 574fa11 and d8f8370.

📒 Files selected for processing (1)
  • deps/internal/vnelogging

📝 Walkthrough

Walkthrough

This PR updates the deps/internal/vnelogging git submodule to a newer commit revision. The submodule pointer changes from fb9c0a335feb250bfc6e9669e8a55bedc205c014 to 62d4d22b24c243ad47c24310a4e120e52b32b4c9, affecting which version of the vnelogging dependency is checked out by the repository.

Changes

vnelogging Submodule Pointer Update

Layer / File(s) Summary
vnelogging submodule revision bump
deps/internal/vnelogging
The submodule reference is updated to a new commit, checking out a different revision of the vnelogging dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A hop, a skip, a commit hash swap,
The vnelogging dependency hops to the top,
From old to new, the revision rolls through,
Fresh and ready, dependency too! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: update vnelogging submodule reference' directly and specifically describes the main change—updating a git submodule pointer for vnelogging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch VNE_TEMPLATE_SYNC_LOGGING

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

  • Updates the repository’s pinned deps/internal/vnelogging submodule revision to a newer upstream commit.
  • Primary risk: submodule bumps can introduce API/behavior changes that aren’t visible in this PR’s diff, so downstream build/test compatibility needs to be confirmed.

Changes:

  • Bump deps/internal/vnelogging submodule gitlink to a newer revision.

BLOCKER

  • None identified in the repository’s tracked text files for this PR.

MAJOR

  • Since the actual code changes live in the vnelogging submodule (not in this repo), please ensure CI (or at least local build + tests) is run against this PR and that the updated vnelogging revision is compatible with this template’s current CMake integration (target names, exported configs, options like BUILD_TESTS/BUILD_EXAMPLES, etc.). If possible, include the new submodule commit SHA (or tag) and a short upstream changelog link in the PR description for traceability.

MINOR

  • None.

@ajeetsinghyadav
ajeetsinghyadav merged commit 27aa794 into main May 22, 2026
25 checks passed
@ajeetsinghyadav
ajeetsinghyadav deleted the VNE_TEMPLATE_SYNC_LOGGING branch May 22, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants