Conversation
giuseppeg
commented
Jan 16, 2017
giuseppeg
commented
Contributor
rauchg
reviewed
Jan 17, 2017
|
|
||
| const transform = (file, opts = {}) => ( | ||
| new Promise((resolve, reject) => { | ||
| transformFile(path.resolve(__dirname, file), { |
Member
There was a problem hiding this comment.
shouldn't we avoid the benchmark doing I/O?
Contributor
Author
There was a problem hiding this comment.
Yeah but I am not sure if benchmark supports async setup bestiejs/benchmark.js#174
I can read the file synchronously before exporting the benchmark wdyt?
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.