Add support for expressions within template literals - #80
Merged
Conversation
Conflicts: src/babel.js test/index.js
|
🎉 |
|
👏 |
Closed
Contributor
Author
Ran on a MacBook Pro (Mid 2014), 2.6 GHz Intel Core i5, 8 GB 1600 MHz DDR3 |
|
Anything we can do to help get this merged? |
|
Waiting on this 🍪 |
Member
|
@TuckerWhitehouse @aga5tya I'd like to understand why it's 30% slower, seems a bit much? Also, @giuseppeg, what's the impact on an example that doesn't use expressions, before and after this patch? |
|
@rauchg what would be acceptable performance? I ran the benchmarks locally, and these are my results:
|
|
Re-ran the benchmarks, and updated
|
|
Thanks @rauchg, and nice work @giuseppeg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25