Skip to content

refactor(eve): share temporary directory cleanup in test helpers #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vercel-gh-bot-5 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −19
Draft

refactor(eve): share temporary directory cleanup in test helpers #1780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions packages/eve/src/internal/testing/use-temporary-app-roots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,28 +41,12 @@ export function useTemporaryAppRoots(): (
prefix: string,
options?: CreateTemporaryAppRootOptions,
) => Promise<TemporaryAppRoot> {
const temporaryRoots: string[] = [];

afterEach(async () => {
await Promise.all(
temporaryRoots.splice(0).map(async (directoryPath) => {
try {
await rm(directoryPath, {
force: true,
recursive: true,
});
} catch {
// Best-effort cleanup; a leaked tmpdir must not fail the run.
}
}),
);
});
const createTemporaryDirectory = useTemporaryDirectories();

return async (prefix, options = {}) => {
const appRoot = await mkdtemp(join(tmpdir(), prefix));
const appRoot = await createTemporaryDirectory(prefix);
const agentRoot = join(appRoot, "agent");

temporaryRoots.push(appRoot);
await mkdir(agentRoot, {
recursive: true,
});
Expand Down Expand Up @@ -110,7 +94,7 @@ export function useTemporaryDirectories(): (prefix: string) => Promise<string> {
recursive: true,
});
} catch {
// Best-effort cleanup.
// A leaked temporary directory must not fail the test.
}
}),
);
Expand Down