Add Vitest unit tests + CI step - #30
Merged
Merged
Conversation
- unit tests for the pure, bug-prone helpers: ids (genJoinCode charset/length, genId UUID) and mappers (mapRoom deck/null parsing, mapProfile prefs + safe bad-JSON) - 'npm test' (vitest run) added to the CI checks (PR -> main) Note: route/integration tests via @cloudflare/vitest-pool-workers were attempted but the current vitest 4 + pool combo is unstable (removed defineWorkersConfig / unsupported runner); left as a follow-up. Unit tests: 4 passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automated tests + runs them in CI.
ids(join-code charset/length, UUID) andmappers(room deck/null parsing, profile prefs + safe handling of bad JSON). 4 tests, all passing.npm test(vitest run) added to the CI checks on PRs.Note: I tried route/integration tests via
@cloudflare/vitest-pool-workers, but the currentvitest@4+ pool combo is unstable (it droppeddefineWorkersConfigand the pool runner errors as 'not supported'). Rather than ship a broken/flaky config, I kept reliable unit tests and left the integration harness as a follow-up (would need a known-good vitest+pool pin). The routes are already covered by manual E2E checks on each feature.