fix(ci): sync lockfile (npm 10) — repair broken CI/Deploy on main - #31
Merged
Conversation
The lock generated by local npm 11 omitted esbuild's platform optionalDependencies, which npm 10 (used by setup-node@v4 + node 20 in CI) requires for 'npm ci'. Regenerated with npm 10; verified 'npm ci' passes.
The macOS-generated lockfile omits Linux-only native binaries (esbuild/ rollup/rolldown optionalDependencies, npm/cli#4828), so 'npm ci' fails on the CI/Deploy runners. Switch both workflows to 'npm install' (fetches the right platform binaries) and downgrade vitest 4 -> 3 to avoid rolldown's native binding entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #30 was merged while its CI was red, so
mainnow has a lockfile thatnpm cirejects (generated by npm 11, missing esbuild's platform optionalDependencies that npm 10 — used in CI/Deploy — requires). This broke both the CI and the Deploy workflow on main.(Prod is unaffected — it's still running the last good deploy, v3.7; the failed
npm cimeantwrangler deploynever ran, and the tests are dev-only anyway. But the pipeline is red and future deploys are blocked until this lands.)Fix: regenerated
package-lock.jsonwith npm 10 sonpm cipasses on both CI's npm and locally. Verifiednpm ci,npm test(4 passing) andbuildlocally.Merge this to turn CI + Deploy green again.