[REFACTOR] Webhook 전용 HTTP client 분리 및 timeout 정책 정리#95
Open
minyongP wants to merge 1 commit into
Open
Conversation
kwongwangjae
left a comment
Member
There was a problem hiding this comment.
Webhook timeout 설정 때문에 이렇게 한거지?? 진욱이형이랑 확인하고 체크하면 될듯??
Contributor
Author
|
그건 아니고 기존에 restTemplate쓸때 judge0 설정이랑 같이 적으면서 결합도가 커져서 좀 분리하려고 |
Member
|
아 오키오키 확인했슴다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 작업 / 이슈
내용 요약 (Description)
Judge0와 Webhook이 공유하던
RestTemplatewiring을 분리했습니다.Judge0/Webhook 외부 연동 설정을 각 패키지(
external/judge0,external/webhook)로 이동했습니다.Webhook 전용 timeout 설정(
app.webhook-alert.http.*)을 추가했습니다.SubmissionService,RestTemplateWebhookSender가 각각 명시적인 전용 bean을 주입받도록 변경했습니다.내용:
judge0RestTemplate,webhookRestTemplate분리WebhookConfig,WebhookHttpProperties,Judge0Config추가application.yml,application-test.yml에 Webhook timeout 설정 추가테스트
./gradlew compileJava compileTestJavacom.ujax.infrastructure.external.judge0.Judge0ConfigTestcom.ujax.infrastructure.external.webhook.WebhookConfigTestcom.ujax.infrastructure.external.webhook.RestTemplateWebhookSenderTestcom.ujax.application.submission.SubmissionServiceTest./gradlew verify자동 실행 및 통과 후 push 완료PR 체크리스트
./gradlew verify를 로컬에서 실행해 모두 통과함.Breaking Change 여부
로그 / 스크린샷 (선택)
기타 정보 / 의존성 (선택)
SubmissionService에서 Judge0 external client 추상화 분리 ([제안] SubmissionService에서 Judge0 external client 분리 #94)