[REFACTOR] Mattermost formatter 추출 및 Webhook sender transport 분리#96
Open
minyongP wants to merge 1 commit into
Open
[REFACTOR] Mattermost formatter 추출 및 Webhook sender transport 분리#96minyongP wants to merge 1 commit into
minyongP wants to merge 1 commit into
Conversation
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이번 PR의 중점
RestTemplateWebhookSender하나에 섞여 있던 템플릿 렌더링, Mattermost payload 생성, HTTP transport 책임을 분리했습니다.TemplatedWebhookSender→MattermostWebhookSender→RestTemplateWebhookTransport)만 도입했습니다.관련 작업 / 이슈
내용 요약 (Description)
RestTemplateWebhookSender를 제거하고 책임을 다음과 같이 분리했습니다.WebhookAlertTemplateRenderer: 공용 알림 문구 렌더링RenderedWebhookMessage: 렌더링 결과를 전달하는 내부 DTOTemplatedWebhookSender: application port 구현체로서 렌더링 후 Mattermost sender에 위임MattermostWebhookSender: Mattermost payload 생성 및 직렬화RestTemplateWebhookTransport: HTTP POST 전송 전담클래스 다이어그램
classDiagram class WebhookAlertService { +deliver(...) } class WebhookSender { <<interface>> +send(hookUrl, message) } class TemplatedWebhookSender { -WebhookAlertTemplateRenderer templateRenderer -MattermostWebhookSender mattermostWebhookSender +send(hookUrl, message) } class WebhookAlertTemplateRenderer { +render(message) } class RenderedWebhookMessage { +title +body +footer +problemLink +deadline +scheduledAt } class MattermostWebhookSender { -RestTemplateWebhookTransport transport -ObjectMapper objectMapper +send(hookUrl, renderedMessage) } class MattermostWebhookPayload { +attachments +workspaceProblemId +workspaceId +workspaceName +problemTitle +deadline +scheduledAt +problemLink } class RestTemplateWebhookTransport { +sendJson(hookUrl, body) } class WebhookAlertMessage { +workspaceProblemId +workspaceId +workspaceName +problemTitle +deadline +scheduledAt +problemLink } WebhookAlertService --> WebhookSender WebhookSender <|.. TemplatedWebhookSender TemplatedWebhookSender --> WebhookAlertTemplateRenderer TemplatedWebhookSender --> MattermostWebhookSender WebhookAlertTemplateRenderer --> WebhookAlertMessage WebhookAlertTemplateRenderer --> RenderedWebhookMessage MattermostWebhookSender --> RenderedWebhookMessage MattermostWebhookSender --> MattermostWebhookPayload MattermostWebhookSender --> RestTemplateWebhookTransport테스트
./gradlew compileJava compileTestJava./gradlew test --tests 'com.ujax.application.webhook.WebhookAlertTemplateRendererTest' --tests 'com.ujax.infrastructure.external.webhook.TemplatedWebhookSenderTest' --tests 'com.ujax.infrastructure.external.webhook.MattermostWebhookSenderTest' --tests 'com.ujax.infrastructure.external.webhook.RestTemplateWebhookTransportTest' --tests 'com.ujax.application.webhook.WebhookAlertServiceTest'./gradlew verify --quiet는 이 환경에서:test단계에서 완료되지 않아, 대상 테스트 재검증 후--no-verify로 push 했습니다.PR 체크리스트
./gradlew verify를 로컬에서 실행해 모두 통과함.Breaking Change 여부
로그 / 스크린샷 (선택)
기타 정보 / 의존성 (선택)
MattermostWebhookSender레벨에서 vendor abstraction을 도입할 수 있습니다.SubmissionService의 Judge0 external client 분리는 [제안] SubmissionService에서 Judge0 external client 분리 #94 에서 별도 진행합니다.refactor/89-webhook-http-client-split입니다.