Repository navigation
Retry the push of the binaries when another job pushed first - #1334
Closed
nigrosimone wants to merge 1 commit into
Closed
nigrosimone wants to merge 1 commit into
nigrosimone wants to merge 1 commit into
Conversation
Comment on lines
+5
to
+6
| # Every run pushes to the same branch, so runs wait for each other | ||
| concurrency: ${{ github.workflow }} |
Contributor
There was a problem hiding this comment.
What does this mean? We want them to continue running in parallel like before
| # The jobs push to the same branch: when another one pushed first, rebase and try again. | ||
| # Its own step because the one above runs in PowerShell on Windows | ||
| - name: Push binaries | ||
| shell: bash |
Contributor
There was a problem hiding this comment.
I don't like this, it creates even more non-native, excotic dependencies on Windows (of which I am trying to minimize - I want the Windows runner to basically run on native PowerShell). You kind of need to find some commonality between PowerShell and Bash
Contributor
Author
|
I wanted to try to fix the random failures, but maybe it is not a good idea. Closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and Build ASAN failed today at the push, after the build and the tests had passed:
binariesfirstBoth end with
rejected (fetch first), and that platform keeps the old binaries until the next merge.Now the runs of each workflow wait for each other (
concurrency), and a rejected push rebases and tries again, up to 5 times. The jobs change different.nodefiles, so the rebase is clean. On Windows the build step runs in PowerShell, so there the push is its own step in bash.Checked with two clones racing on a local repo: the second push is rejected, rebases and goes through with both binaries; when both change the same file it still fails. actionlint is clean.