Repository navigation
Retry the push of the binaries when another job pushed first, in one line for PowerShell and bash - #1345
Merged
Conversation
…line for PowerShell and bash
nigrosimone
marked this pull request as ready for review
October 1, 2026 17:39
Contributor
|
I like this. Minimal complexity, cross platform, no new deps or assumptions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same goal as #1334, without its two problems: the runs stay parallel, and nothing new runs on Windows.
Build and Build ASAN sometimes fail at the push after the build and the tests passed, because another job pushed to
binariesin between, and that platform keeps the old binaries until the next merge.Now a rejected push takes the other commit and tries again, up to three times. It is one line of git with
&&and||, which PowerShell 7 and bash read the same way, left to right.-X theirskeeps this job's version of a file both changed, likesource_commit.Tested on my fork with the four runners of build.yml pushing to one branch in the same second, each in its default shell (run): one went in at the first try, two at the second, macOS at the third, and the branch had all four files.