Skip to content

Stop app icons flickering when the launcher opens #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nchudleigh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop app icons flickering when the launcher opens #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ui/ResultRow.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,19 @@ Item {
anchors.verticalCenter: parent.verticalCenter

Image {
// Not `visible`: that turns false whenever the launcher hides, which
// dropped every icon and reloaded it blank on the next open.
readonly property bool wanted: row.iconName.length > 0 && row.glyph.length === 0
anchors.fill: parent
visible: row.iconName.length > 0 && row.glyph.length === 0
visible: wanted
fillMode: Image.PreserveAspectFit
asynchronous: true
// Keep the old icon while a new source or size decodes, instead of a
// blank frame (Qt 6.8+).
retainWhileLoading: true
sourceSize.width: width * Screen.devicePixelRatio
sourceSize.height: height * Screen.devicePixelRatio
source: !visible ? "" : (row.appLibrary ? row.appLibrary.iconSource(row.iconName) : Quickshell.iconPath(row.iconName, "application-x-executable"))
source: !wanted ? "" : (row.appLibrary ? row.appLibrary.iconSource(row.iconName) : Quickshell.iconPath(row.iconName, "application-x-executable"))
}

Text {
Expand Down