Repository navigation
Stop app icons flickering when the launcher opens - #67
Open
nchudleigh wants to merge 1 commit into
Open
nchudleigh wants to merge 1 commit into
nchudleigh wants to merge 1 commit into
Conversation
The icon's source was `!visible ? "" : ...`, and `visible` is effective visibility: it turns false whenever the launcher hides. Every hide dropped every app icon and every open reloaded it asynchronously, so image icons (apps, unlike glyph icons) drew blank for a few frames, and again as the size settled. Key the source on whether the row has an icon instead, and keep the previous image while a reload decodes (retainWhileLoading). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App icons blink off and on for a few frames each time the launcher opens. Glyph icons don't, only image icons (apps).
The icon's source is
!visible ? "" : …, andvisibleis effective visibility, so it turns false whenever the launcher hides. Every hide drops every app icon, and every open reloads it asynchronously: blank until it decodes, then again assourceSizesettles. A 60 fps screen recording showed the app icon going blank twice within the first few frames of opening, and per-row logging showed Loading → Ready → Loading → Ready with the same source.Change
wanted), not on effective visibility, so hiding the launcher keeps decoded icons.retainWhileLoading: truekeeps the previous image while a new source or size decodes (Qt 6.8+; Omarchy 4 ships 6.12).Testing
node --test tests/*.test.jspasses. Checked with a 60 fps recording before and after (frames below).Screenshots
Four consecutive 60 fps frames as the launcher opens. Before, the app icon blanks every other frame:
After:
🤖 Generated with Claude Code