Repository navigation
Conversation
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.1. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.1/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Dependabot #982 bumped package.json only, so bun install --frozen-lockfile failed in CI. Regenerated against registry.npmjs.org; changes are limited to vitest and its transitive deps (vitest 5.0.2, @vitest/mocker/spy 5.0.2, magic-string 1.x, tinybench 6, why-is-node-running 3, ...).
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Bumps vitest 4.x to 5.0.1 and regenerates bun.lock so frozen-lockfile CI passes; dev-dependency only with no source/config changes, migration checklist verified, and identical test results plus fault-injection checks confirm correctness.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failure on #982 (Dependabot: vitest 4.1.11 -> 5.0.1). Supersedes #982 if merged; #982 itself can then be closed.
What changed
package.json: Dependabot's commit from chore(deps-dev): bump vitest from 4.1.11 to 5.0.1 #982 cherry-picked unchanged (vitest ^4.1.2 -> ^5.0.1).bun.lock: regenerated sobun install --frozen-lockfilepasses. chore(deps-dev): bump vitest from 4.1.11 to 5.0.1 #982 changed onlypackage.json, so every CI job died at Install dependencies (error: lockfile had changes, but lockfile is frozen). The lockfile diff (+31/-35) is limited to vitest and its transitive deps: vitest 5.0.2, @vitest/mocker + @vitest/spy 5.0.2, @vitest/expect/runner/snapshot/utils/pretty-format removed (inlined upstream), magic-string 1.x, tinybench 6, why-is-node-running 3, plus nested pins keeping existing consumers (vite, sucrase, @jridgewell) on their previous versions. Resolved against registry.npmjs.org (no private-registry URLs).Vitest 5 migration checklist (https://vitest.dev/guide/migration)
clearMocksnow default true: onlyworker.debug-sentry.test.jsasserts call counts, and it already resets the mock inbeforeEach; behavior unchanged.vi.mockmust be top-level: both uses (worker.http-semantics,worker.debug-sentry) are top-level.sequentialremoval,toThrow(""),expect.poll, fake timers, bench, deprecated entry points, projects/extends: not used..vitest/artifacts dir: already in.gitignore.vitest listis now static collection, so dynamicit.each/loop tests show as template names there; test-set comparison below uses real-run JSON reporter output instead.Evidence (local, macOS arm64, bun 1.4.0, node 22.23)
bun install --frozen-lockfileon chore(deps-dev): bump vitest from 4.1.11 to 5.0.1 #982 head: fails (reproduced). On this branch: exit 0.bun run build: exit 0.vitest runbase (main 8b1951c, vitest 4.1.2) vs this branch (vitest 5.0.2), JSON reporter: 59 files / 712 tests / 712 passed on both; 0 test names only in one side, 0 status differences.toThrowexpectation insrc/services/qr.test.jsmakes vitest 5 exit 1 (reverted), so failures are still detected.PW_PORToverride, same head); CI E2E (Playwright) on this PR: both runs green.Risk
Dev-dependency only; no runtime/Worker code changes. Main risk is a test-runner behavior change masking a regression; mitigated by identical test set and pass/fail status vs base and the fault-injection check.
Rollback
Revert this PR's merge commit (restores vitest 4 and the old lockfile).
Summary by cubic
Bumps vitest from
^4.1.2to^5.0.1and regeneratesbun.locksobun install --frozen-lockfilepasses in CI. Supersedes #982, which only changedpackage.jsonand caused every CI job to fail at the install step.The lockfile diff is limited to vitest and its transitive deps; no config or test changes were needed.
Migration
Written for commit deb1b0a. Summary will update on new commits.