fix: normalize archive entry names and manifest paths to forward slashes#223
Open
fix: normalize archive entry names and manifest paths to forward slashes#223
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
On Windows, PathBuf joins use backslashes, which leaked into tar archive entry names and the manifest import_paths field. This caused test failures on windows-latest CI and would break cross-platform package extraction. Reuse the existing normalize_path() helper for all archive entry names (app files, module files) and manifest import_path strings so they always use forward slashes regardless of the host OS.
bradhe
force-pushed
the
fix/windows-path-separators-in-packages
branch
from
ac4acd5 to
28b926b
Compare
bradhe
requested review from
codingcyclist,
jo-sm,
konstantinoscs,
sammuti and
socksy
sammuti
approved these changes
Mar 10, 2026
socksy
approved these changes
Mar 10, 2026
Contributor
socksy
left a comment
socksy
left a comment
There was a problem hiding this comment.
Some of the comments sound a bit LLMy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
PathBufjoins use\as the separator. This leaked into tar archive entry names and theimport_pathsmanifest field, causing:windows-latest:it_packages_import_paths_nested_within_base_dir— manifest containedmodules\\sharedinstead ofmodules/sharedFix
Reuse the existing
normalize_path()helper (already used for checksum computation) for all archive entry names and manifest strings:import_pathsentriesAll paths are now consistently forward-slash regardless of host OS.
Testing
All 10 package tests pass, including
it_packages_import_paths_nested_within_base_dirwhich specifically covers this case.