feat: add react-hook-philosophy plugin by kimyouknow · Pull Request #366 · toss/react-simplikit

kimyouknow · 2026-04-03T07:40:35Z

Summary

Initial draft of react-hook-philosophy as a Claude Code plugin, defining 31 hook design principles for code review and writing guidance.

31 principles: C1-C14 (coding principles from CLAUDE.md) + U1-U17 (usage patterns from react.dev)
2 skills: react-hook-review (checklist) + react-hook-writing (guide)
3 reference hooks: useToggle, useDebounce, useMediaQuery with anti-pattern comparisons

Files

File	Description
`docs/hook-design-principles.md`	Design document (requirements + C1-C14 + architecture + roadmap)
`docs/react-hook-usage-patterns.md`	React hook usage patterns (U1-U17 from react.dev)
`packages/plugin/`	Claude Code plugin structure

Validation

claude plugin validate ✅ passed
Project reference grep: 0 matches ✅
SKILL.md token budget: review 598w, writing 552w (< 1500w limit) ✅

Install (after merge)

claude plugin install --source git-subdir \
  --url https://github.com/toss/react-simplikit.git \
  --path packages/plugin

Test plan

Run /react-hook-review locally → verify checklist feedback
Run /react-hook-writing locally → verify guide + patterns reference
Discuss Q1-Q6 decisions and reflect changes
Test git-subdir install from another React project

Add Claude Code plugin with 31 hook design principles (C1-C14 coding + U1-U17 usage patterns) for code review and writing guidance. Includes design document, React hook usage patterns reference, and 3 complete hook implementation examples.

autofix-troubleshooter · 2026-04-03T07:41:33Z

Hi! I'm the autofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

github-actions · 2026-04-03T07:42:56Z

Size Change: 0 B 🆕

Total Size: 0 B

_{compressed-size-action}

- Move C8 (guard clauses) and C11 (function keyword) from Required to Recommended - Add U12 (useSyncExternalStore) to writing guide - Fix anti-pattern table: count check uses == null instead of !== undefined - Add MIT LICENSE file

- Convert hook-design-principles.md and react-hook-usage-patterns.md to English - Add react.dev source URLs and quotes to all U1-U17 patterns - Move Korean originals to docs/ko/ for reference

kimyouknow · 2026-04-07T13:28:48Z

+// ✅ const intervalRef = useRef<number | null>(null);
+```
+
+### U4. 복잡한 관련 state는 useReducer


check for review

useReducer is an app-level state management pattern, not a hook library design principle. Removed from all docs and plugin review checklist.

- C1, C7: mark as project conventions with notes (React allows arbitrary returns) - C3: correct "cleanup required" → "cleanup when subscribing" (React says optional) - C2: add react.dev/hydrateRoot source URL - U6, U9, U10, U11, U13, U14, U16: replace paraphrased quotes with actual react.dev text

zztnrudzz13 · 2026-04-14T20:51:11Z

+
+```bash
+claude plugin install --source git-subdir \
+  --url https://github.com/kimyouknow/react-simplikit.git \


I think you should change the url path!

…dangling - plugin.json + README install URL: kimyouknow -> toss (addresses zztnrudzz13 review) - LICENSE: align copyright with root repo (Viva Republica, Inc) - Remove dangling U4 (useReducer) reference from react-hook-writing/SKILL.md after U4 was removed from usage patterns - README principle counts: 31 -> 30, "17 usage patterns" -> "16 (U4 excluded)", State Design 7 -> 6 - react-design-principles SKILL.md: promote Zero-Dependency Bias to section 5 to match references/principles.md; React design count 4 -> 5 - hook-design-principles.md Opinionated breakdown: "13 + 1" -> "11 + 3 (C1, C7, C14)" to match inline markings - hook-design-principles.md section 3: "17 patterns" -> "16 patterns (U4 removed)" - Korean docs: mark C1/C7 inline 🟡 for parity with EN, sync date to 2026-04-21

…ophy Reflects broader scope after the react-design-principles skill was added. The plugin now covers higher-level React API design (declarative interfaces, lifecycle safety, minimal surface, reliability, zero-dependency bias) in addition to hook review and writing.

The plugin has not been published yet, so documenting the pre-release name change is unnecessary noise. The rename is recorded in git history.

Credits the contributor who added the react-design-principles skill.

- Drop "Last Updated" / "최종 업데이트" header lines from all four doc files (git history is authoritative for update dates) - Fix remaining "17 principles" / "17개 원칙" drift in usage-patterns intro lines to match the U4-removed count (16)

The GitHub login matches the git commit author identifier, so it's unambiguous and ties directly to commit history.

Resolves CI 'quality (format)' and 'autofix' failures. All 8 files flagged by prettier check are now formatted consistently.

changeset-bot · 2026-04-21T14:16:27Z

⚠️ No Changeset found

Latest commit: 50dc900

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kimyouknow added 2 commits April 6, 2026 12:00

fix: address PR review feedback for plugin

a118d94

- Move C8 (guard clauses) and C11 (function keyword) from Required to Recommended - Add U12 (useSyncExternalStore) to writing guide - Fix anti-pattern table: count check uses == null instead of !== undefined - Add MIT LICENSE file

docs: translate design docs to English, add Korean versions to docs/ko/

6510de6

- Convert hook-design-principles.md and react-hook-usage-patterns.md to English - Add react.dev source URLs and quotes to all U1-U17 patterns - Move Korean originals to docs/ko/ for reference

kimyouknow commented Apr 7, 2026

View reviewed changes

kimyouknow added 2 commits April 7, 2026 22:37

docs: remove U4 (useReducer) from hook usage patterns

dff1b32

useReducer is an app-level state management pattern, not a hook library design principle. Removed from all docs and plugin review checklist.

zztnrudzz13 reviewed Apr 14, 2026

View reviewed changes

zztnrudzz13 and others added 8 commits April 15, 2026 05:54

feat: add react design principle skills in claude plugin

d5a7cdf

docs(plugin): remove pre-release rename note from README

1dea102

The plugin has not been published yet, so documenting the pre-release name change is unnecessary noise. The rename is recorded in git history.

chore(plugin): add Sookyung (zztnrudzz13) as co-author

934b39f

Credits the contributor who added the react-design-principles skill.

chore(plugin): use zztnrudzz13 GitHub handle instead of Sookyung

7022e4a

The GitHub login matches the git commit author identifier, so it's unambiguous and ties directly to commit history.

Merge branch 'main' into feat/hook-design-plugin

73af5ba

kimyouknow marked this pull request as ready for review April 21, 2026 13:21

kimyouknow and others added 4 commits April 21, 2026 22:26

style: apply prettier formatting to plugin docs

73da09b

Resolves CI 'quality (format)' and 'autofix' failures. All 8 files flagged by prettier check are now formatted consistently.

Merge branch 'main' into feat/hook-design-plugin

a747a45

Merge remote-tracking branch 'origin/main' into feat/hook-design-plugin

63f218c

chore: trigger changeset-bot verification

4683b24

Merge branch 'main' into feat/hook-design-plugin

50dc900

kimyouknow merged commit b89cd4a into main Apr 21, 2026
11 checks passed

kimyouknow deleted the feat/hook-design-plugin branch April 21, 2026 14:25

kimyouknow mentioned this pull request Apr 21, 2026

fix(plugin): add marketplace.json so the install command actually works #374

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add react-hook-philosophy plugin#366

feat: add react-hook-philosophy plugin#366
kimyouknow merged 18 commits intomainfrom
feat/hook-design-plugin

kimyouknow commented Apr 3, 2026 •

edited

Loading

Uh oh!

autofix-troubleshooter commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

kimyouknow Apr 7, 2026

Uh oh!

zztnrudzz13 Apr 14, 2026

Uh oh!

changeset-bot Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kimyouknow commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Files

Validation

Install (after merge)

Test plan

Uh oh!

autofix-troubleshooter commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kimyouknow Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

zztnrudzz13 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

changeset-bot Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kimyouknow commented Apr 3, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

changeset-bot Bot commented Apr 21, 2026 •

edited

Loading