fix(plugin): add marketplace.json so the install command actually works#374
Merged
kimyouknow merged 2 commits intomainfrom Apr 21, 2026
Merged
fix(plugin): add marketplace.json so the install command actually works#374kimyouknow merged 2 commits intomainfrom
kimyouknow merged 2 commits intomainfrom
Conversation
The previous README install command used --source/--url/--path flags that Claude Code's plugin CLI does not support, and the plugin lacked the marketplace.json required by the CLI. Result: the documented install flow was impossible to execute. Changes: - Add packages/plugin/.claude-plugin/marketplace.json with a single plugin entry whose source is "./" (marketplace and plugin share the same directory) - Rewrite the README install section to use the real two-step flow: marketplace add (with --sparse for the monorepo) followed by plugin install Verified end-to-end locally: - claude plugin validate . → passes - claude plugin marketplace add . → adds "react-design-philosophy" - claude plugin install ... → installs v0.1.0, status enabled - claude plugin uninstall ... → cleanly removes
|
Contributor
|
Size Change: 0 B 🆕 Total Size: 0 B |
plugin.json's description is already the authority under strict mode (default), so repeating it in the marketplace entry adds noise without behavioural effect. - Verified install flow still works end-to-end after the removal - Plugin list still shows the description (inherited from plugin.json)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #366 merged, the
react-design-philosophyplugin is impossible to install because it ships onlyplugin.json, not themarketplace.jsonrequired byclaude plugin. The README install command also references CLI flags (--source,--url,--path) that don't exist in the currentclaude pluginCLI.This PR fixes both.
Evidence of the bug on current main
Changes
packages/plugin/.claude-plugin/marketplace.json— declares a single-plugin marketplace whosesourcepoints at"./"(plugin and marketplace share the same directory)## Installsection — replace the non-existent--source git-subdirflags with the real two-step flowVerified locally end-to-end
claude plugin validate .claude plugin marketplace add . --scope localreact-design-philosophyclaude plugin install react-design-philosophy@react-design-philosophyclaude plugin listclaude plugin uninstall …Test plan
/react-design-principles,/react-hook-review,/react-hook-writingare available after install