Skip to content

fix(plugin): add marketplace.json so the install command actually works#374

Merged
kimyouknow merged 2 commits intomainfrom
fix/plugin-install-marketplace
Apr 21, 2026
Merged

fix(plugin): add marketplace.json so the install command actually works#374
kimyouknow merged 2 commits intomainfrom
fix/plugin-install-marketplace

Conversation

@kimyouknow
Copy link
Copy Markdown
Collaborator

Summary

After #366 merged, the react-design-philosophy plugin is impossible to install because it ships only plugin.json, not the marketplace.json required by claude plugin. The README install command also references CLI flags (--source, --url, --path) that don't exist in the current claude plugin CLI.

This PR fixes both.

Evidence of the bug on current main

$ claude plugin marketplace add /path/to/packages/plugin
✘ Failed to add marketplace: Marketplace file not found at
  packages/plugin/.claude-plugin/marketplace.json

$ claude plugin install --help
Usage: claude plugin install [options] <plugin>
Options:
  -s, --scope <scope>    # (no --source / --url / --path)

Changes

  1. Add packages/plugin/.claude-plugin/marketplace.json — declares a single-plugin marketplace whose source points at "./" (plugin and marketplace share the same directory)
  2. Rewrite README ## Install section — replace the non-existent --source git-subdir flags with the real two-step flow

Verified locally end-to-end

Step Command Result
1 claude plugin validate . ✅ Passed
2 claude plugin marketplace add . --scope local ✅ Added react-design-philosophy
3 claude plugin install react-design-philosophy@react-design-philosophy ✅ Installed v0.1.0, enabled
4 claude plugin list ✅ Listed
5 claude plugin uninstall … ✅ Cleanly removed

Test plan

  • After merge, run the README command set against the published repo from a fresh directory
  • Confirm /react-design-principles, /react-hook-review, /react-hook-writing are available after install

The previous README install command used --source/--url/--path flags
that Claude Code's plugin CLI does not support, and the plugin lacked
the marketplace.json required by the CLI. Result: the documented
install flow was impossible to execute.

Changes:
- Add packages/plugin/.claude-plugin/marketplace.json with a single
  plugin entry whose source is "./" (marketplace and plugin share
  the same directory)
- Rewrite the README install section to use the real two-step flow:
  marketplace add (with --sparse for the monorepo) followed by
  plugin install

Verified end-to-end locally:
- claude plugin validate .         → passes
- claude plugin marketplace add .  → adds "react-design-philosophy"
- claude plugin install ...        → installs v0.1.0, status enabled
- claude plugin uninstall ...      → cleanly removes
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: 698c68a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

plugin.json's description is already the authority under strict mode
(default), so repeating it in the marketplace entry adds noise without
behavioural effect.

- Verified install flow still works end-to-end after the removal
- Plugin list still shows the description (inherited from plugin.json)
@kimyouknow kimyouknow marked this pull request as ready for review April 21, 2026 14:45
@kimyouknow kimyouknow requested a review from zztnrudzz13 as a code owner April 21, 2026 14:45
@kimyouknow kimyouknow merged commit 77fe507 into main Apr 21, 2026
11 checks passed
@kimyouknow kimyouknow deleted the fix/plugin-install-marketplace branch April 21, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant