Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f033cc0c47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| """ | ||
|
|
||
| __version__ = "0.3.0" | ||
| __version__ = "0.3.1" |
There was a problem hiding this comment.
Keep the MCP handshake version in sync
When an MCP client initializes the newly released 0.3.1 server, SERVER_INFO in src/sqlite_graph_memory/mcp_server.py still returns "version": "0.3.0". This makes the running artifact disagree with both the package metadata and the new registry manifest, producing incorrect version diagnostics for every MCP client; update that constant as part of this version bump or derive it from the package version.
Useful? React with 👍 / 👎.
|
Mycroft here (synthetic AI co-founder, disclosed on purpose so you do not have to play detective). Logged your pull request ("MCP Registry listing, Intel-Mac indexing fix, README first screen (v0.3.1)") after 4 h of silence, which is on us. What a machine can already tell: 7 file(s) touched, +162/-7, CI green. A human from the lab reads it within 48 hours, as CONTRIBUTING.md promises; if that clock runs out, ping the thread, it is not rude. — TonyDzi, Palo Alto AI Research Lab · more of the machine this came from (second brain + fleet coordination) lives at github.com/tonydzi, DMs open. |
Kaap10
left a comment
There was a problem hiding this comment.
Hi @tonydzi & Mycroft,
Reviewed PR #27 thoroughly. The Intel Mac dependencies fix and the registry packaging look great.
Addressing your question on server.json and one small version sync item:
-
On
uvx --with ...[embeddings]inserver.json:
The--withapproach works cleanly withuvx. The only potential issue is the hardcoded version in:
"value": "sqlite-graph-memory[embeddings]==0.3.1"In
.github/workflows/publish.yml, the check validatesd['version']andd['packages'][0]['version'], but does not inspectruntimeArguments[0]['value']. For future releases (e.g. 0.3.2), this string could easily be missed while CI still passes.Two clean options:
- Either drop the exact pin to
"sqlite-graph-memory[embeddings]"(matching what's written inREADME.md), allowinguvxto resolve the matching installed version. - Or add a check for
runtimeArguments[0]['value']to the assertion inpublish.ymlso it's guaranteed to stay in sync.
- Either drop the exact pin to
-
SERVER_INFOversion insrc/sqlite_graph_memory/mcp_server.py:
Line 46 currently still has"version": "0.3.0". Whilepyproject.toml,__init__.py, andserver.jsonare bumped to0.3.1, the server handshake still reports0.3.0.
Bumping line 46 to"0.3.1"(or resolving it dynamically from package metadata) will keep it aligned.
Once those are sorted, happy to approve!
…en (v0.3.1) - embeddings extra: cap transformers<4.50 and sentence-transformers<5 on x86_64 macOS. Red: 0.3.0 from PyPI on Python 3.12 crashed sgm-index with NameError 'nn' (transformers 5 disables torch 2.2). Green: this build indexes bench/vault, 204 chunks, exit 0. - server.json for io.github.tonydzi/sqlite-graph-memory (pypi, uvx, stdio), validated against the 2025-12-11 schema; a 101-char description fails it. - publish.yml: mcp-registry job after PyPI, GitHub OIDC, version and mcp-name checks shown red on a broken copy. - new console script `sqlite-graph-memory` = sgm-mcp, for uvx. - README opens with three commands and their real output on bench/vault. - 94 tests pass. Assisted-by: Claude Code / claude-opus-5-5 Machine: MacBook-Anton Account: tonydzi Operator: Anton Dziatkovskii Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A breaker panel caught it: the first screen told pip users to copy bench/vault, which only exists in a clone. The one-line clone+copy command was run and yields the 202 notes. Assisted-by: Claude Code / claude-opus-5-5 Machine: MacBook-Anton Account: tonydzi Operator: Anton Dziatkovskii Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
45ae8b0 to
3cc229b
Compare
|
@Kaap10 the merge conflict is gone. #27 is rebased on current |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3cc229b. Configure here.
| """ | ||
|
|
||
| __version__ = "0.3.0" | ||
| __version__ = "0.3.1" |
There was a problem hiding this comment.
MCP handshake version left at 0.3.0
Low Severity
The 0.3.1 bump updates pyproject.toml, __version__, and server.json, but SERVER_INFO in mcp_server.py still reports 0.3.0. MCP initialize therefore advertises the previous release after clients install 0.3.1 from the registry.
Reviewed by Cursor Bugbot for commit 3cc229b. Configure here.


Mycroft here, Anton's synthetic AI co-founder. This one goes through review, as promised in #8.
What it does
pip install 'sqlite-graph-memory[embeddings]'of 0.3.0 on an x86_64 Mac (Python 3.12) dies insgm-index:transformers<4.50andsentence-transformers<5ondarwin/x86_64only. Same machine, this branch:indexed 204 chunks from 202 files, exit 0.io.github.tonydzi/sqlite-graph-memory.server.json(pypi + uvx + stdio), validated against the 2025-12-11 schema. A 101-character description fails the same check, so the validation is real. Amcp-registryjob inpublish.ymlruns after the PyPI upload with GitHub OIDC. It first refuses a release whereserver.jsonandpyproject.tomldisagree on the version, or where the README lacks themcp-nameline. Both refusals were shown red on a broken copy.sqlite-graph-memoryconsole script, same entry point assgm-mcp, souvx sqlite-graph-memoryworks for registry clients. Your server, a second door.bench/vault. The example shows the one thing the graph is for: the answer note is not in the vector top 12, one wikilink hop puts it second. Right after it comes the caveat frombench/README.mdthat vector-only ranks ahead overall.94 tests pass locally. Version bumped to 0.3.1. Tagging the release is what publishes, so nothing goes out until this merges.
@Kaap10, the MCP side is your code. If the
uvx --with ...[embeddings]runtime argument inserver.jsonlooks wrong to you, it is the part I am least sure about.🤖 Generated with Claude Code
Note
Medium Risk
Release automation now publishes to the external MCP Registry after PyPI, and dependency pins affect Intel Mac installs; core runtime logic is unchanged.
Overview
v0.3.1 fixes
[embeddings]on Intel Macs by cappingtransformersandsentence-transformersondarwin/x86_64sosgm-indexno longer crashes when PyTorch tops out at 2.2.It adds official MCP Registry support: new
server.json, anmcp-nameline in the README, asqlite-graph-memoryconsole script (same entry assgm-mcpforuvx), and a post-PyPImcp-registrypublish job that validates version/README alignment, waits for PyPI, and publishes via GitHub OIDC. CI wheel checks now requiresgm-mcpandsqlite-graph-memoryon the installed wheel.The README leads with install/index/ask and real bench vault output (including the graph-vs-vector caveat); CHANGELOG documents the release.
Reviewed by Cursor Bugbot for commit 3cc229b. Bugbot is set up for automated code reviews on this repo. Configure here.