Skip to content

Fix self-correction rules on macOS 26 and the gaps from #30; add Dependabot and CodeQL - #31

Merged
tobymarks merged 2 commits into
mainfrom
fix/text-rules-ci
Oct 20, 2026
Merged

tobymarks merged 2 commits into
mainfrom
fix/text-rules-ci

Conversation

@tobymarks

Copy link
Copy Markdown
Owner

Text rules (#22, #30)

Locally (macOS 27): 54 tests, 0 failures; swiftlint --strict clean. Website before/after examples don't use any of these patterns. Windows has no tidy step, so TestData/text-pipeline.json is unchanged. Not tried with real dictations yet.

Supply chain (#28, partly)

  • .github/dependabot.yml: GitHub Actions + NuGet (windows/), monthly, grouped. Swift packages stay pinned by hand (FluidAudio ↔ model files, Sparkle ↔ feed).
  • .github/workflows/codeql.yml: actions + csharp, build-mode none. No Swift (would need a full Xcode build per run).
  • windows.yml: actions pinned to commit SHAs like the other workflows.
  • Branch protection / required reviews: not done, the maintainer decides.

Closes #22, closes #30, refs #28.

🤖 Generated with Claude Code

tobymarks and others added 2 commits October 20, 2026 12:05
The macOS test suite has been red on the runner since Oct 12 (#22):
NLTagger on macOS 26 does not give "September" and "Oktober" the same
kind, while macOS 27 does, so a one-word correction depended on the OS
version. German number words were skipped for the same reason (#30).
Digits, German and English number words, months and weekdays now count
as one kind from fixed lists; NLTagger stays the fallback for the rest.

Two more rule gaps from #30:
- A filler between two commas left a comma behind ("ist, um zehn").
  Both commas now go, except when the speaker restarts with a word just
  said ("bis Freitag, äh, bis Donnerstag") or an aside continues.
- The dot of a date ("am 12. September") split the sentence, so a
  correction across it was never found and capitalisation went wrong.

Closes #22
Closes #30

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Suggestions from the OpenSSF Scorecard report in #28. Dependabot runs
monthly and grouped, for GitHub Actions and the Windows NuGet packages;
the Swift packages stay pinned by hand because FluidAudio has to match
the model files and Sparkle the update feed. CodeQL covers the workflows
and the C# code with build-mode none; Swift would need a full Xcode build
per run. windows.yml still used tag references, now commit SHAs like the
other workflows.

Branch protection and required reviews are left to the maintainer.

Refs #28

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@tobymarks
tobymarks merged commit 629ce1d into main Oct 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants