Repository navigation
Keep the comma in front of a filler again before 0.6.0 - #38
Merged
Merged
Conversation
Everywhere else the German interface calls them Textbausteine; the new footer was the only place that said Snippets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#30.1 dropped both commas around a filler so that "ist, äh, um zehn" loses its stray comma. Most commas in front of a filler belong to the sentence, though: "Ich glaube, äh, dass das stimmt" became "Ich glaube dass das stimmt", and greetings, names, relative and infinitive clauses lost theirs too. Found while checking the 0.6.0 release, before anything was published. A stress test of 528 realistic sentences with a filler between two commas (German letters and chat, German speech, English) found the right commas in 67 % with 0.5.1's rule, 42 % with #30.1 and 47 % with word lists for the comma-needing cases on top. So 0.6.0 ships 0.5.1's rule; a better one needs its own attempt with these sentences (#30). The other #31 fixes stay: German number words, the dot after a day and fixed month/weekday lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes found while checking the Mac 0.6.0 release, before anything was published.
Tidy: keep the comma in front of a filler (takes back #30.1)
#31 made "Tidy up dictations" drop both commas around a filler (
Das Meeting ist, äh, um zehn.→Das Meeting ist um zehn.). But most commas in front of a filler belong to the sentence. 0.5.1 kept these; #31 deleted them:A stress test ran 528 realistic sentences with a filler between two commas through three versions: German letters and chat, German speech and prompts, and English. Each was compared with the correct commas, and every reported failure went to a second checker.
The sentences leaned towards boundaries where a comma is needed. Even so, the word lists were whack-a-mole: relative and infinitive clauses, names, appositions and enumerations stayed broken, and "Danke, äh, für …" and "Sehr gerne, äh, komme ich …" got worse. So 0.6.0 ships 0.5.1's rule.
ist, äh, um zehnkeeps one comma too many again, as in every released version. A better rule needs its own attempt with these sentences (#30).The other #31 fixes stay: German number words, the dot after a day (
am 12. September) and fixed month/weekday lists (#22).German footer
The new per-app rules footer said „Snippets“. Everywhere else the German UI says „Textbausteine“.
Checks
testTidyKeepsTheCommaInFrontOfAFillerin place oftestTidyDropsCommasThatOnlyFramedAFiller.swiftlint --strictclean andcheck-localizations.pypasses.TestData/text-pipeline.jsonis unchanged.Refs #30, #31.
🤖 Generated with Claude Code