Skip to content

test(docs): witness policy validate offline and move it covered in the docs ledger - #5511

Open
auser wants to merge 1 commit into
mainfrom
fix/5369-bdd-aarch64-ci
Open

auser wants to merge 1 commit into
mainfrom
fix/5369-bdd-aarch64-ci

Conversation

@auser

@auser auser commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

What

Since #5488 landed the console-EIO and cookbook env fixes and listed mvmctl policy validate ./policy/api-group.toml in the docs coverage ledger as uncovered debt, this PR completes that debt the way the ledger's header asks ("moving a line from uncovered to covered is the point of the file"):

  • New s29 scenario: stage the policies guide's own group file (./policy/api-group.toml) in a scratch directory and run policy validate against it offline; exits 0 and prints policy is valid under --verbose.
  • Regenerated ledger: all three documented policy validate examples move uncovered → covered; entries whose doc lines recent PRs removed leave the ledger.

No production code changes; the earlier console/mdx fixes in this branch's history were identical to #5488 and dropped during the rebase.

Validation

  • s29 doc-examples suite on rebased main: 25 scenarios / 52 steps, all passed, in both ledger-update and ratchet modes
  • just check::gated clean (before rebase; the remaining diff is feature/toml/step files only, re-verified by the suite run above)

Refs #5369

CI (main) has failed twice in a row on 50b1a23 with three jobs:
BDD conformance (2 scenarios), Test workspace (aarch64), and the
meta-lane that requires every lane to pass.

- The operations cookbook's TypeScript example still assigned a bare
  string env value; #5463 made EnvValue explicit, so the documented
  example no longer typechecks. Write MODE: literal("dev") and import
  literal.
- mvmctl policy validate ./policy/api-group.toml is newly documented
  and sat outside the coverage ledger. Add a scenario that stages the
  guide's own group file in a scratch directory and validates it
  offline, then regenerate the ledger: the policy-validate examples
  move from uncovered debt to covered, and entries whose doc lines
  recent PRs removed leave the ledger.
- a_console_spawned_shell_holds_no_capabilities read the pty master
  with read_to_end, which propagates EIO; EIO is how a pty master
  reports that every slave holder has closed it, so a fast-exiting
  shell failed the read on the aarch64 runner. Treat EIO as end of
  stream, matching pump_output's contract.

Refs #5369
@auser
auser force-pushed the fix/5369-bdd-aarch64-ci branch 2 times, most recently from 03cab35 to 86044aa Compare November 14, 2026 23:55
@auser auser changed the title fix(ci): restore the BDD and aarch64 CI witnesses on main test(docs): witness policy validate offline and move it covered in the docs ledger Nov 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant