Repository navigation
Conversation
CI (main) has failed twice in a row on 50b1a23 with three jobs: BDD conformance (2 scenarios), Test workspace (aarch64), and the meta-lane that requires every lane to pass. - The operations cookbook's TypeScript example still assigned a bare string env value; #5463 made EnvValue explicit, so the documented example no longer typechecks. Write MODE: literal("dev") and import literal. - mvmctl policy validate ./policy/api-group.toml is newly documented and sat outside the coverage ledger. Add a scenario that stages the guide's own group file in a scratch directory and validates it offline, then regenerate the ledger: the policy-validate examples move from uncovered debt to covered, and entries whose doc lines recent PRs removed leave the ledger. - a_console_spawned_shell_holds_no_capabilities read the pty master with read_to_end, which propagates EIO; EIO is how a pty master reports that every slave holder has closed it, so a fast-exiting shell failed the read on the aarch64 runner. Treat EIO as end of stream, matching pump_output's contract. Refs #5369
4 of 5 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The last two CI (main) runs (43523161932, 43535542677 on 50b1a23) fail three jobs: BDD conformance (2 scenarios), Test workspace (aarch64), and the "Require every lane to pass" meta-lane. This fixes all three causes.
operations-cookbook.mdxassignedMODE: "dev"as a bare string; feat(sdk): retire bare-string env values in the SDKs and decorator parser (#4839) #5463 madeEnvValueexplicit, so the documented example fails the typecheck scenario (TS2322). NowMODE: literal("dev")withliteralimported.mvmctl policy validate ./policy/api-group.toml(documented in the policies guide) sat outside the coverage ledger, and the ratchet failed on it before reaching stale debt behind it. Adds a scenario staging the guide's own group file in a scratch directory and validating it offline (--verboseso the success line is observable), then regenerates the ledger: the threepolicy validateexamples moveuncovered → covered, and entries whose doc lines recent PRs removed leave the ledger.a_console_spawned_shell_holds_no_capabilitiesread the pty master withread_to_end, which propagates EIO. EIO is how a Linux pty master reports that every holder of the slave side has closed it, so a fast-exitingsh -c grepfailed the read on the aarch64 runner (x86_64 timing masks the race). The read loop now treats EIO as end of stream, matchingpump_output's documented contract.Validation
just check::gated(linux-gated + bdd targets): cleanmvm-agentd --tests,mvm-conformance --features bdd --tests):-D warningscleanpump_output's EIO handling, and the job will re-witness on this PR's aarch64 runner.Lifecycle
Test-only/doc-only change; no runtime state transitions touched. The new scenario owns a tempdir scratch dir + isolated home, dropped on process exit as the existing steps do.
Refs #5369