Repository navigation
Centralize review snapshot comparison and fallback - #2
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ClearanceNo review requirements were triggered. Warnings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review snapshot loading previously delegated patchset comparison back to the HTTP server, so callers had to assemble review behavior themselves.
loadReviewSnapshotnow owns indexed lookup, selected-head comparison, file projection and review-mark retention, and public fallback. The server supplies request parameters and GitHub client setup.Comparison failures retain the indexed data with an explicit limitation, empty comparisons remain empty, and database failures propagate. Snapshot tests exercise the complete interface with a controlled index adapter and mocked GitHub transport, including rename marks, patch normalization, public fallback, and failure paths; redundant public-loader-only coverage was replaced.
Validation:
npm run typecheck,npm run lint,npm test(170 tests),npm run format, andnpm run buildall pass.