Skip to content

Centralize review snapshot comparison and fallback - #2

Merged
timReynolds merged 1 commit into
mainfrom
codex/review-snapshot-module
Sep 13, 2026
Merged

timReynolds merged 1 commit into
mainfrom
codex/review-snapshot-module

Conversation

@timReynolds

Copy link
Copy Markdown
Owner

Review snapshot loading previously delegated patchset comparison back to the HTTP server, so callers had to assemble review behavior themselves. loadReviewSnapshot now owns indexed lookup, selected-head comparison, file projection and review-mark retention, and public fallback. The server supplies request parameters and GitHub client setup.

Comparison failures retain the indexed data with an explicit limitation, empty comparisons remain empty, and database failures propagate. Snapshot tests exercise the complete interface with a controlled index adapter and mocked GitHub transport, including rename marks, patch normalization, public fallback, and failure paths; redundant public-loader-only coverage was replaced.

Validation: npm run typecheck, npm run lint, npm test (170 tests), npm run format, and npm run build all pass.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T21:54:23.738247Z 45167e8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clearance-app-tr

Copy link
Copy Markdown

Clearance

No review requirements were triggered.

Warnings

  • examples/OWNERS.toml $.escalation.fallback_team: GitHub team @org/platform-leads was not found
  • examples/OWNERS.toml $.rule[0].require[0].from: GitHub team @org/platform-eng was not found
  • examples/OWNERS.toml $.rule[0].require_any[0].from: GitHub team @org/security-eng was not found
  • examples/OWNERS.toml $.rule[0].require_any[1].from: GitHub team @org/compliance was not found
  • examples/OWNERS.toml $.rule[1].require[0].from: GitHub team @org/platform-eng was not found
  • examples/OWNERS.toml $.rule[1].require[1].from: GitHub team @org/security-eng was not found
  • examples/OWNERS.toml $.notify[0].teams[0]: GitHub team @org/compliance was not found
  • examples/OWNERS.toml $.override.teams[0]: GitHub team @org/repo-admins was not found

@timReynolds
timReynolds added this pull request to stack #5 September 13, 2026 21:59
@timReynolds
timReynolds merged commit c18731d into main Sep 13, 2026
1 of 4 checks passed
@timReynolds
timReynolds deleted the codex/review-snapshot-module branch September 18, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant