Skip to content

Concentrate native review actions and index reconciliation - #4

Merged
timReynolds merged 1 commit into
codex/review-snapshot-modulefrom
codex/review-action-module
Sep 13, 2026
Merged

timReynolds merged 1 commit into
codex/review-snapshot-modulefrom
codex/review-action-module

Conversation

@timReynolds

@timReynolds timReynolds commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner

Builds on #2.

Review mutations currently mix HTTP handling, GitHub writes, marker creation, and index updates in server.ts. If GitHub accepts a comment, resolution, or review and the following index update fails, the route reports a generic failure even though the native action already happened.

Move that flow into createReviewActions, with GitHub and review-index adapters at its test seam. HTTP retains authentication, CSRF, request validation, and response adaptation. Accepted native writes now return success with persisted: false and a warning when the index update throws; file-viewed mirroring remains best effort after the local mark. Replies and resolution require a recoverable GitHub reference before changing local state. Comment creation tolerates failure of its optional thread lookup, and later resolution can recover the thread through the stored root comment ID.

Validation: typecheck, lint, all 189 tests on the snapshot branch, format, production build, and all 16 browser tests pass. New tests cover native/index partial failures, imported references, review attention, viewed-file mirroring, and real HTTP routing/authentication/CSRF with mocked startup and external adapters. No live GitHub or Postgres writes were exercised. Warning fields are returned by the HTTP interface; this change does not add UI rendering or background index repair.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T22:00:38.997872Z 038cf3d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clearance-app-tr

clearance-app-tr Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Clearance

No review requirements were triggered.

Warnings

  • examples/OWNERS.toml $.escalation.fallback_team: GitHub team @org/platform-leads was not found
  • examples/OWNERS.toml $.rule[0].require[0].from: GitHub team @org/platform-eng was not found
  • examples/OWNERS.toml $.rule[0].require_any[0].from: GitHub team @org/security-eng was not found
  • examples/OWNERS.toml $.rule[0].require_any[1].from: GitHub team @org/compliance was not found
  • examples/OWNERS.toml $.rule[1].require[0].from: GitHub team @org/platform-eng was not found
  • examples/OWNERS.toml $.rule[1].require[1].from: GitHub team @org/security-eng was not found
  • examples/OWNERS.toml $.notify[0].teams[0]: GitHub team @org/compliance was not found
  • examples/OWNERS.toml $.override.teams[0]: GitHub team @org/repo-admins was not found

@timReynolds
timReynolds force-pushed the codex/review-action-module branch from 038cf3d to 2153d08 Compare September 13, 2026 21:59
@timReynolds
timReynolds changed the base branch from main to codex/review-snapshot-module September 13, 2026 21:59
@timReynolds
timReynolds added this pull request to stack #5 September 13, 2026 21:59
@timReynolds
timReynolds merged commit 3bead61 into main Sep 13, 2026
1 of 4 checks passed
@timReynolds
timReynolds deleted the codex/review-action-module branch September 18, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant