Repository navigation
Concentrate native review actions and index reconciliation - #4
Merged
timReynolds merged 1 commit intoSep 13, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ClearanceNo review requirements were triggered. Warnings
|
timReynolds
force-pushed
the
codex/review-action-module
branch
from
September 13, 2026 21:59
038cf3d to
2153d08
Compare
timReynolds
changed the base branch from
main
to
codex/review-snapshot-module
September 13, 2026 21:59
timReynolds
added this pull request to stack #5
September 13, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #2.
Review mutations currently mix HTTP handling, GitHub writes, marker creation, and index updates in
server.ts. If GitHub accepts a comment, resolution, or review and the following index update fails, the route reports a generic failure even though the native action already happened.Move that flow into
createReviewActions, with GitHub and review-index adapters at its test seam. HTTP retains authentication, CSRF, request validation, and response adaptation. Accepted native writes now return success withpersisted: falseand a warning when the index update throws; file-viewed mirroring remains best effort after the local mark. Replies and resolution require a recoverable GitHub reference before changing local state. Comment creation tolerates failure of its optional thread lookup, and later resolution can recover the thread through the stored root comment ID.Validation: typecheck, lint, all 189 tests on the snapshot branch, format, production build, and all 16 browser tests pass. New tests cover native/index partial failures, imported references, review attention, viewed-file mirroring, and real HTTP routing/authentication/CSRF with mocked startup and external adapters. No live GitHub or Postgres writes were exercised. Warning fields are returned by the HTTP interface; this change does not add UI rendering or background index repair.