Skip to content

Fix NoticeBar component wrap #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davinotdavid wants to merge 2 commits into
base: main
Choose a base branch
from
+47 −35
Draft

Fix NoticeBar component wrap #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b062f97
Update NoticeBar component to use flex and flex-wrap instead of grid
davinotdavid Jun 24, 2026
1978080
Update padding on link buttons
davinotdavid Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/BaseButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ button:hover > .tooltip {
box-shadow: none !important;
border: none !important;
min-width: 0;
padding: 0.5rem 0.75rem;

.text {
padding: 0;
Expand Down
6 changes: 3 additions & 3 deletions src/components/NoticeBar.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export const CTAControls: Story = {
render: () => ({
components: { NoticeBar, PrimaryButton, LinkButton },
template: `
<notice-bar>
This form is dirty.
<notice-bar type="warning">
You have unsaved changes.

<template #cta>
<link-button>Revert changes</link-button>
Expand All @@ -54,7 +54,7 @@ export const CTAControls: Story = {
parameters: {
docs: {
source: {
code: '<notice-bar>\n This form is dirty.\n\n <template #cta>\n <link-button>Revert changes</link-button>\n <primary-button size="small">Save changes</primary-button>\n </template>\n</notice-bar>',
code: '<notice-bar type="warning">\n You have unsaved changes.\n\n <template #cta>\n <link-button>Revert changes</link-button>\n <primary-button size="small">Save changes</primary-button>\n </template>\n</notice-bar>',
},
},
},
Expand Down
75 changes: 43 additions & 32 deletions src/components/NoticeBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,17 @@ const isError = computed(() => props.type === NoticeBarTypes.Critical);

<template>
<div :class="{ [type]: type }" class="notice notice-bar" :data-testid="dataTestid">
<span class="icon">
<notice-info-icon v-if="isInfo" />
<notice-success-icon v-if="isSuccess" />
<notice-warning-icon v-if="isWarning" />
<notice-critical-icon v-if="isError" />
</span>
<span class="body">
<slot />
</span>
<div class="notice-bar-content">
<span class="icon">
<notice-info-icon v-if="isInfo" />
<notice-success-icon v-if="isSuccess" />
<notice-warning-icon v-if="isWarning" />
<notice-critical-icon v-if="isError" />
</span>
<span class="body">
<slot />
</span>
</div>
<div class="cta" v-if="$slots?.cta">
<slot name="cta" />
</div>
Expand All @@ -43,42 +45,51 @@ const isError = computed(() => props.type === NoticeBarTypes.Critical);
<style scoped>
@import '@/assets/styles/custom-media.pcss';

.icon {
.notice {
display: flex;
justify-content: space-between;
align-items: center;
justify-content: center;
}
border-radius: 1rem;
border: 0.0625rem solid;
padding: 1rem;
flex-wrap: wrap;
gap: 0.5rem;

.body {
font-size: 1rem;
font-weight: 400;
line-height: 132%;
color: var(--colour-ti-secondary);
flex-grow: 1;
&:has(.cta) {
padding: 0.75rem 0.75rem 0.75rem 1rem;
}
}

.cta {
.notice-bar-content {
display: flex;
align-items: center;
justify-content: center;
gap: 1rem;
}

.notice {
display: grid;
grid-template-columns: auto 1fr auto;
justify-content: start;
align-items: center;
border-radius: 1rem;
gap: 0.5rem;
border: 0.0625rem solid;
padding: 1rem;
flex-wrap: wrap;

&:has(.cta) {
padding: 0.75rem 0.75rem 0.75rem 1rem;
.icon {
display: flex;
align-items: center;
justify-content: center;
}

.body {
font-size: 1rem;
font-weight: 400;
line-height: 132%;
color: var(--colour-ti-secondary);
flex-grow: 1;
}
}

.cta {
display: flex;
align-items: center;
justify-content: center;
gap: 1rem;
flex-wrap: wrap;
}

.info {
background-color: var(--colour-primary-soft);
border-color: var(--colour-primary-default);
Expand Down
Loading