Fix NoticeBar component wrap#294
Draft
davinotdavid wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
NoticeBarcomponent to use flex and flex-wrap instead of grid + media queries so that it wraps up it's content nicely.BaseButtoncomponent'sLinkvariant to have less padding as it has always been larger than it should affecting surrounding components (NoticeBar grew in height with a Link button within it).Why?
NoticeBar had not been coded with responsiveness in mind and would break in smaller viewports. Also, the Link button had a larger padding that wasn't revised until now.
Applicable Issues
Related with thunderbird/appointment#1718
Closes #293
Screenshots
Video of responsiveness
Screen.Recording.2026-06-24.at.3.27.57.PM.mov