Regenerate tools: House-only coverage note, and the missing filings tool - #33
Merged
Merged
Conversation
Two things came out of one codegen run against the live spec. The congress tool now tells the model what it is actually querying. We hold House PTRs only -- Senate eFD blocks datacenter traffic -- and until now the tool description advertised "chamber (House|Senate)" with no hint that one of those matches nothing. That is worse here than in the REST API: an assistant reading this description will confidently filter by Senate, get an empty array, and report "no senate trades found" to a user as if it were a fact about Congress. The description and the chamber param both now carry the coverage note and point at the X-Coverage-Note header. list_filings was missing entirely. GET /v1/filings shipped in insiderapi #206 on 2026-08-04 -- built because four distinct users had 404'd that path 382 times -- and the codegen pass on 2026-08-10 did not pick it up, so the endpoint has existed for eight days with no MCP tool. Found by running codegen:check during an unrelated copy sweep, which is not a reliable way to notice a missing tool. Tool count 34 -> 35, free tools 21 -> 22, since /v1/filings is ungated. README counts, the tool table and the expected-name list in the test all updated; that hardcoded count is what caught the addition. codegen:check now reports in sync. 65/65 tests. Not published to npm.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both changes fell out of one
npm run codegenagainst the live spec, during an unrelated public-copy sweep.1. The congress tool now says what it actually covers
We hold House PTRs only — Senate eFD blocks datacenter traffic. Until now the tool description advertised
chamber (House|Senate)with no hint that one of those matches nothing.This matters more in MCP than in the REST API. An assistant reading the old description will confidently filter by Senate, receive an empty array, and report "no Senate trades found" to a user as though it were a fact about Congress. The description and the
chamberparam now both carry the coverage note and point atX-Coverage-Note: chamber-not-covered(insiderapi #215).2.
list_filingswas missing entirelyGET /v1/filingsshipped in insiderapi #206 on 2026-08-04 — built because four distinct users had 404'd that path 382 times over 90 days. The codegen pass on 2026-08-10 did not pick it up, so the endpoint has existed for eight days with no MCP tool.Found by running
codegen:checkduring a copy sweep, which is not a reliable way to notice a missing tool. Worth consideringcodegen:checkin CI.Counts
34 → 35 tools, 21 → 22 free (
/v1/filingsis ungated). README header, tool table, plan matrix and the expected-name list in the test all updated — that hardcoded count is what caught the addition in the first place.Verification
npm run codegen:check→ in sync with the live OpenAPI specnpm test→ 65/65, plus 3/3 generated-path testsnpm run buildcleanNot published to npm — that's a separate call.