Fix scripted attachment UI's render phase ordering - #672
Open
TheLostInPlace wants to merge 1 commit into
Open
TheLostInPlace wants to merge 1 commit into
TheLostInPlace wants to merge 1 commit into
Conversation
Item and camera attachment UIs (custom_ui_func screens, detector screens, script attachments) were drawn after phase_combine, straight onto the back buffer, so night vision, LUT, bloom and TAA never touched them while HUD meshes and the 3D PDA screen got all of them. Draw them in render_forward ahead of r_dsgraph_render_sorted_hud, the order the non-MT renderer uses, so the post chain covers them and a glass pane in front of a device screen blends over it the way the 3D PDA glass does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item and camera attachment UIs (
custom_ui_funcscreens, detector screens, script attachments) were drawn after phase_combine, straight onto the back buffer, so night vision, LUT, bloom and TAA never touched them while HUD meshes and the 3D PDA screen got all of them.Draw them in render_forward ahead of r_dsgraph_render_sorted_hud, the order the non-MT renderer uses, so the post chain covers them and a glass pane in front of a device screen blends over it the way the 3D PDA glass does.
TL;DR
Issue was exposed by Wearable Devices, this PR essentially fixes an oversight in the MT UI rendering pathway that non-MT gets right.