Repository navigation
refactor(config)!: finish ciphernode configuration ownership - #2409
Merged
neogiacomo merged 1 commit intoNov 4, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Architecture changeFrom
Every change (14)
Experimental. The page goes away when the pull request closes. |
This was referenced Nov 2, 2026
neogiacomo
marked this pull request as ready for review
November 2, 2026 16:23
neogiacomo
force-pushed
the
refactor/2383-config-final-owner
branch
from
November 2, 2026 16:55
2063240 to
660747e
Compare
neogiacomo
added a commit
that referenced
this pull request
Nov 2, 2026
Move e3-entrypoint to crates/ciphernode/entrypoint with workspace, Docker, production guard, documentation, and blueprint references updated together. Keep the unified CLI and CLI-owned initializer at their standalone roots. Remove the unused empty config module and flatten the peer-ID and startup implementations into their module roots, migrating CLI callers directly. Preserve operation bodies, tests, fixtures, package identity, features, configuration behavior, durable locations, and protocol/runtime behavior. Part of #2383; stacked on #2409. The owner approved the atomic whole-crate exception: 115 old/new review paths and 69 rename-folded files. BREAKING CHANGE: e3_entrypoint::net::get_peer_id::execute becomes e3_entrypoint::net::execute; start::start::{execute, ingestion_heartbeat_dir, write_ingestion_expectation} moves directly under e3_entrypoint::start. The unused config export is removed. No aliases, operator reset/resync, protocol change, or release-counter change.
neogiacomo
force-pushed
the
refactor/2383-config-final-owner
branch
from
November 3, 2026 13:09
660747e to
3ac906b
Compare
neogiacomo
added a commit
that referenced
this pull request
Nov 3, 2026
Move e3-entrypoint to crates/ciphernode/entrypoint with workspace, Docker, production guard, documentation, and blueprint references updated together. Keep the unified CLI and CLI-owned initializer at their standalone roots. Remove the unused empty config module and flatten the peer-ID and startup implementations into their module roots, migrating CLI callers directly. Preserve operation bodies, tests, fixtures, package identity, features, configuration behavior, durable locations, and protocol/runtime behavior. Part of #2383; stacked on #2409. The owner approved the atomic whole-crate exception: 115 old/new review paths and 69 rename-folded files. BREAKING CHANGE: e3_entrypoint::net::get_peer_id::execute becomes e3_entrypoint::net::execute; start::start::{execute, ingestion_heartbeat_dir, write_ingestion_expectation} moves directly under e3_entrypoint::start. The unused config export is removed. No aliases, operator reset/resync, protocol change, or release-counter change.
neogiacomo
force-pushed
the
refactor/2383-config-final-owner
branch
from
November 3, 2026 13:40
3ac906b to
b7c157f
Compare
neogiacomo
added a commit
that referenced
this pull request
Nov 3, 2026
Move e3-entrypoint to crates/ciphernode/entrypoint with workspace, Docker, production guard, documentation, and blueprint references updated together. Keep the unified CLI and CLI-owned initializer at their standalone roots. Remove the unused empty config module and flatten the peer-ID and startup implementations into their module roots, migrating CLI callers directly. Preserve operation bodies, tests, fixtures, package identity, features, configuration behavior, durable locations, and protocol/runtime behavior. Part of #2383; stacked on #2409. The owner approved the atomic whole-crate exception: 115 old/new review paths and 69 rename-folded files. BREAKING CHANGE: e3_entrypoint::net::get_peer_id::execute becomes e3_entrypoint::net::execute; start::start::{execute, ingestion_heartbeat_dir, write_ingestion_expectation} moves directly under e3_entrypoint::start. The unused config export is removed. No aliases, operator reset/resync, protocol change, or release-counter change.
9 tasks
neogiacomo
added a commit
that referenced
this pull request
Nov 4, 2026
Move e3-entrypoint to crates/ciphernode/entrypoint with workspace, Docker, production guard, documentation, and blueprint references updated together. Keep the unified CLI and CLI-owned initializer at their standalone roots. Remove the unused empty config module and flatten the peer-ID and startup implementations into their module roots, migrating CLI callers directly. Preserve operation bodies, tests, fixtures, package identity, features, configuration behavior, durable locations, and protocol/runtime behavior. Part of #2383; stacked on #2409. The owner approved the atomic whole-crate exception: 115 old/new review paths and 69 rename-folded files. BREAKING CHANGE: e3_entrypoint::net::get_peer_id::execute becomes e3_entrypoint::net::execute; start::start::{execute, ingestion_heartbeat_dir, write_ingestion_expectation} moves directly under e3_entrypoint::start. The unused config export is removed. No aliases, operator reset/resync, protocol change, or release-counter change.
Move network/bootstrap policy and compiled release identity into e3-ciphernode-config with their unchanged release manifest and tests. Migrate direct consumers and the contract-tooling reader, remove unused dependencies, and delete e3-config without a compatibility facade. Preserve configuration behavior, exact release identity, counters, durable locations, P2P protocol names, and runtime admission policy. Update owner guidance, Docker/workspace inputs, diagnostics, and blueprint references. Part of #2383; stacked on #2407. BREAKING CHANGE: network and release imports now use e3_ciphernode_config; e3-config is removed. The release manifest now lives at crates/ciphernode/config/protocol-release.toml. No operator reset or resync is required.
neogiacomo
added a commit
that referenced
this pull request
Nov 4, 2026
Move e3-entrypoint to crates/ciphernode/entrypoint with workspace, Docker, production guard, documentation, and blueprint references updated together. Keep the unified CLI and CLI-owned initializer at their standalone roots. Remove the unused empty config module and flatten the peer-ID and startup implementations into their module roots, migrating CLI callers directly. Preserve operation bodies, tests, fixtures, package identity, features, configuration behavior, durable locations, and protocol/runtime behavior. Part of #2383; stacked on #2409. The owner approved the atomic whole-crate exception: 115 old/new review paths and 69 rename-folded files. BREAKING CHANGE: e3_entrypoint::net::get_peer_id::execute becomes e3_entrypoint::net::execute; start::start::{execute, ingestion_heartbeat_dir, write_ingestion_expectation} moves directly under e3_entrypoint::start. The unused config export is removed. No aliases, operator reset/resync, protocol change, or release-counter change.
neogiacomo
force-pushed
the
refactor/2383-config-final-owner
branch
from
November 4, 2026 10:11
c39b240 to
e6af8da
Compare
neogiacomo
temporarily deployed
to
github-pages
November 4, 2026 10:32 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2383; stacked on #2407. Next: #2410.
Move network/release configuration and
protocol-release.tomlintocrates/ciphernode/config,migrate Rust and contract-tooling readers, then delete
e3-config. No facade or old-import aliases.Deliberate Rust API/import changes; no protocol, wire, or schema change relative to current
main.November 4 rebase and verification evidence
main2da6f43cd(fix(zk-prover): validate ZK readiness #2231), through the preceding stack PR. Head:e6af8daa4..dev.3, advisory lockfiles, deployment/docs updates, and main's CI layout. Obsoletea5b09c342remains absent.e3-configfacade, aliases, duplicate ownership, or counter change. The canonical release writer and four release-file tests pass; identity is unchanged:main. Review references: persistence/replay, network delivery, upgrades, repository testing.