Repository navigation
docs(contracts): add the identity gate audit pack - #2380
Closed
hmzakhalid wants to merge 4 commits into
Closed
hmzakhalid wants to merge 4 commits into
hmzakhalid wants to merge 4 commits into
Conversation
Scope, threat model, invariants, known limits, test evidence, and focus areas for an audit of the owner identity gate and its ZKPassport adapter.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the
|
Verifier changes affect future registrations only; recovery needs credentials that cover the window, a refresh after a revocation, and an admission-policy change during a pause; an unrevoked identifier can be renewed after it expired.
This was referenced Oct 30, 2026
hmzakhalid
marked this pull request as ready for review
October 30, 2026 20:43
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Stacked on #2372. Docs only. This adds
packages/interfold-contracts/audits/identity-gate.md, thepack that an auditor starts from:
feat(dashboard): verify a bond owner with ZKPassport #2378 page, feat(contracts): add the identity gate rollout scripts #2379 rollout), and what stays out (ZKPassport's contracts and circuits).
windows, and governance.
ZKPassport keys; fail-closed capacity at window starts; and others).
fork test. Focus areas for the auditor.
The audits README links it.
Verification
pnpm check:links: 0 errors. Prettier. The facts come from the code at the listed heads and fromthe PR descriptions of feat(contracts): gate committee admission on bond-owner identity #2371 and feat(contracts): verify bond-owner identity with ZKPassport proofs #2372.
Review
Codex gpt-6.1-sol at maximum effort checked every claim against the code: the heads and the
Solidity scope match, and the pack discloses the mock-only proof coverage. Fixed in
85954f131:verifier changes affect future registrations only; recovery needs credentials that cover the window,
a refresh after a revocation, and an admission-policy change during a pause; an unrevoked identifier
can be renewed after it expired.
Compatibility
Docs only. Part of the identity stack: #2371 and #2372 first, then #2377, #2378, #2379, and this
PR.