Allow CI to run advanced/regular Go validation separately - #166
Open
dplyukhin wants to merge 1 commit into
Open
Conversation
dplyukhin
marked this pull request as draft
August 28, 2026 21:34
dplyukhin
force-pushed
the
go-sample-toolchain-matrix
branch
from
August 28, 2026 21:42
179fa06 to
fe915f7
Compare
dplyukhin
marked this pull request as ready for review
August 28, 2026 21:56
dplyukhin
changed the title
tconley1428
reviewed
Aug 31, 2026
| @@ -38,6 +40,10 @@ pub fn validate(request: &ValidateRequest) -> Result<()> { | |||
| ValidationLanguage::Python => validate_python(&repo_root)?, | |||
| ValidationLanguage::Typescript => validate_typescript(&repo_root)?, | |||
| ValidationLanguage::Go => validate_go(&repo_root)?, | |||
Collaborator
There was a problem hiding this comment.
What's the difference between Go and GoRegular? Does Go do both but not work? Or does it only not work in CI?
dplyukhin
force-pushed
the
go-sample-toolchain-matrix
branch
from
September 2, 2026 22:12
fe915f7 to
5d9a2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
cargo validate go-regularandcargo validate go-advancedcommands that validate just the "regular" and "advanced" samples, respectively.samples/go/go.modadvanced/samples/go/go.mod.Why?
The regular and advanced Go samples use different Go toolchains, so they need to be set up separately.
Checklist
Closes: N/A
How was this tested:
cargo validate go-regularcargo validate go-advancedcargo test -p xtaskcargo fmt --check.github/workflows/ci.ymlwith Ruby YAMLgit diff --checkAny docs updates needed?
No.