[WIT] Update Go support file to use internal APIs - #164
Open
dplyukhin wants to merge 3 commits into
Open
Conversation
dplyukhin
force-pushed
the
advanced-go-internals
branch
from
August 28, 2026 21:36
c57aa9e to
85c364a
Compare
dplyukhin
force-pushed
the
advanced-go-internals
branch
from
August 28, 2026 21:42
85c364a to
9d9503f
Compare
dplyukhin
marked this pull request as draft
August 28, 2026 21:46
dplyukhin
marked this pull request as ready for review
August 28, 2026 22:00
tconley1428
reviewed
Aug 31, 2026
| } | ||
|
|
||
| func newSystemNexusClient(service string) workflow.NexusClient { | ||
| return internal.NewSystemNexusClient(service) |
Collaborator
There was a problem hiding this comment.
Why are we creating a separate nexus client type? Not that it is wrong, just wondering what it gives us. The separate interception point?
tconley1428
approved these changes
Aug 31, 2026
dplyukhin
force-pushed
the
advanced-go-internals
branch
from
September 2, 2026 22:12
e7e2d13 to
7df6995
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
newSystemNexusClientinstead ofnewNexusClientWhy?
Why not?
Stack
This PR depends on #166 and targets its
go-sample-toolchain-matrixbranch.Checklist
Closes: N/A
How was this tested:
cargo build-examples --lang gocargo validate go-advancedcargo test --features advanced --test generate_go— 50 passedcargo check --all-features --all-targetsgit diff --checkAny docs updates needed?
No.