[WIT] Add Go function name extractors - #165
Open
dplyukhin wants to merge 2 commits into
Open
Conversation
dplyukhin
marked this pull request as draft
August 28, 2026 21:04
dplyukhin
force-pushed
the
advanced-go-name-extractor
branch
from
August 28, 2026 21:36
17b7aa3 to
781cf55
Compare
dplyukhin
force-pushed
the
advanced-go-name-extractor
branch
from
August 28, 2026 21:43
781cf55 to
561edfc
Compare
dplyukhin
marked this pull request as ready for review
August 28, 2026 22:14
tconley1428
reviewed
Aug 31, 2026
| params.iter().any(|param| { | ||
| param.required | ||
| && param.function.as_ref().is_some_and(|function| { | ||
| !is_go_signal_function(function) && function.name_extractor.is_none() |
Collaborator
There was a problem hiding this comment.
Having signal here explicitly isn't a great sign, since that is not a concept in the WIT.
Collaborator
There was a problem hiding this comment.
Yeah, not introduced by this, but we should fix:
fn is_go_signal_function(function: &FunctionFieldSpec) -> bool {
!function.primary
&& function.args_field == "signal_input"
&& matches!(function.alternate_type.as_ref(), Some(TypeSpec::String))
}
dplyukhin
force-pushed
the
advanced-go-name-extractor
branch
from
September 2, 2026 22:12
5ba96fb to
a063eaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
@nexus.function go-name-extractorworkflowFunctionNamehelper tosupport.gomodel.witto use itWhy?
The original
runtime.FuncForPClogic didn't resolve aliases.Checklist
Closes: N/A
How was this tested:
cargo build-examples --lang gogo test ./...cargo test --features advanced --test generate_go— 50 passedcargo check --all-features --all-targetscargo test --features advanced parser::wit::tests::parses_wit_into_selected_language_specgit diff --check advanced-go-internals -- .Any docs updates needed?
No.