Conversation
also update agents.md
Also add a note in AGENTS.md for this
also remove shorthand flags except for -n
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
move retention to subcommand and add get method
![semgrep-managed-scans[bot]](https://avatars.githubusercontent.com/u/56493103?s=60&v=4){kind=small}
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
add installation of gen-commands
Co-authored-by: gregmankes <8827475+gregmankes@users.noreply.github.com>
…h-again Add Go bin to PATH in verify-generation workflow
…main add async operation polling after apply
* fix e2e test * fix .env loading * Fix error handling * refactor async polling
* Use verbose diff flag * Clean up temp file * Use correct namespace field * Set common options * Check correct field * Remove unused funcs * Guard against panic * setup go * Remove unused option set * Fix create namespace with apply * Remove redundancy * Add gha content block * Fix create vs update behavior
More cursor fixes
| } | ||
| if !cctx.JSONOutput { | ||
| cctx.Printer.Print(progressString) | ||
| } |
There was a problem hiding this comment.
Terminal state progress messages are dead code
Low Severity
In PollAsyncOperation, progressString is assigned for all operation states, but for terminal states (FULFILLED, FAILED, CANCELLED, REJECTED), the function returns before reaching the cctx.Printer.Print(progressString) call on line 217. This means the completion/failure progress messages (e.g., "Operation completed successfully") are computed but never printed in non-JSON mode. Only PENDING and IN_PROGRESS messages are ever displayed. The progress string assignment for terminal states is dead code.
| return | ||
| } | ||
| cctx.Options.Fail(fmt.Errorf("unknown command")) | ||
| } |
There was a problem hiding this comment.
Execute can call Fail twice in tests
Medium Severity
When cobra returns an error before PersistentPreRunE runs (e.g., unknown flags), ActuallyRanCommand remains false. Fail is called on line 340 for the cobra error, and then again on line 359 for "unknown command." In production, the first Fail calls os.Exit(1), masking this. In tests, where Fail just captures the error and returns, the second call triggers a panic ("fail called twice").
Note
Medium Risk
Moderate risk due to new authentication flow and cloud resource mutation commands (create/update/delete) plus new CI/release pipelines, though changes are largely additive.
Overview
Introduces a new Go-based
temporal-cloudCLI plugin with generated Cobra commands and supporting client/auth infrastructure.Adds OAuth login/logout (with local token storage + refresh) and a
namespacemanagement surface (get/list/apply/edit/delete, plus targetedretentionandlifecyclesubcommands) with interactive diffs/prompts, idempotent/async operation handling, and integration tests.Sets up repo tooling and automation:
Makefile-driven command generation (commands.yml->commands.gen.go), GitHub Actions for test/build/release (GoReleaser), and updates ignore/docs/owners (.gitignore,README,CODEOWNERS,AGENTS.MD,mise.toml).Written by Cursor Bugbot for commit 7471aa2. This will update automatically on new commits. Configure here.