Skip to content

More cursor fixes - #16

Merged
anekkanti merged 5 commits into
developfrom
more-cursor-fixes
Feb 19, 2026
Merged

More cursor fixes#16
anekkanti merged 5 commits into
developfrom
more-cursor-fixes

Conversation

@khisakuni

@khisakuni khisakuni commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

What was changed

If it is a significant code change, please make sure there is an open issue for this.
We work best with you when we have accepted the idea first before you code. -->

Checklist

  1. Closes

  2. How was this tested:

  • running integration test locally and in CI
  1. Any docs updates needed?

Note

Low Risk
Small, localized changes to CLI lifecycle and OAuth flow error handling; low risk but could affect command timeout cancellation timing and login callback startup behavior.

Overview
Updates the Go toolchain version to 1.25.5 in go.mod and mise.toml.

Fixes a potential resource leak by storing and invoking the context.WithTimeoutCause cancel func created for --command-timeout during PersistentPostRun, and improves OAuth login robustness by surfacing ListenAndServe startup failures (via an error channel) instead of failing silently. Also routes login/logout success messaging through cctx.Printer for consistent output handling.

Written by Cursor Bugbot for commit 1458949. This will update automatically on new commits. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread temporalcloudcli/commands.login.go Outdated
@khisakuni
khisakuni marked this pull request as ready for review February 18, 2026 21:51
@khisakuni
khisakuni requested a review from a team as a code owner February 18, 2026 21:51
@khisakuni
khisakuni requested a review from anekkanti February 18, 2026 21:52
@anekkanti
anekkanti merged commit 7471aa2 into develop Feb 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants