Repository navigation
docs(feature-map): restore #563's Data Compare entry - #574
Merged
Merged
Conversation
#570 moved #563's hand edits into the sources but missed the editor.datacompare row, so the regenerated page dropped the 2,000-row compare window, the shared op cap, useCompareWindow / compareView.ts and the sql-editor-compare-window spec. Put them back in data.js and rebuild. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#570 folded #563's hand edits to
docs/feature-map.htmlintodocs/feature-map/data.js, but missed theeditor.datacomparerow. The regenerated page lost:useCompareWindow,compareView.tssql-editor-compare-windowThis puts them back in
data.jsand rebuilds the page withnpm run docs:feature-map. The drift test (feature-map-build.test.ts) passes.🤖 Generated with Claude Code
Note
Low Risk
Documentation and generated HTML only; no runtime or API behavior changes.
Overview
Restores editor.datacompare details in
docs/feature-map/data.jsthat were dropped when an earlier merge moved the feature map into the shared data file without this row, then regeneratesdocs/feature-map.html.The updated entry documents compare-window behavior (2,000 rows in key order, in-memory filters/paging, apply cap of 2,000 ops), points at
useCompareWindowandcompareView.ts, and lists e2esql-editor-compare-windowalongside the existing multi-target spec.Reviewed by Cursor Bugbot for commit 8bed1fc. Bugbot is set up for automated code reviews on this repo. Configure here.