Repository navigation
docs: compare window, app.write, and workspace ceiling - #563
Merged
Merged
Conversation
Living docs still described a 500-op migrate, OFFSET-only compare, and a Demo role gated by URL allow-list. Update them for the shipped 2,000-row window, the shared migrate cap, read-only as app.write + reads, and the personal-workspace role ceiling. Co-authored-by: huy.ph1988 <huy.ph1988@gmail.com>
huyplb
marked this pull request as ready for review
October 26, 2026 22:18
Contributor
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: bc78b7b9-ef52-46d5-9e48-00b0481f1ec0) |
Contributor
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: eff70514-e50d-4dae-ae59-ef4692a6eb48) |
Contributor
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: ffe17dea-fd7d-4f07-870a-45bb157ac11d) |
huyplb
added a commit
that referenced
this pull request
Oct 31, 2026
docs(feature-map): add SQL Tracer, fold #563's edits into the sources, fail on a stale page
huyplb
added a commit
that referenced
this pull request
Nov 1, 2026
docs(feature-map): restore #563's Data Compare entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs added/updated
Living docs only (no new pages):
docs/user-guide.md— Compare 2,000 rows, 2,000-op migrate cap, personal-workspace role ceiling, Demo /app.write, Redis keys as tablesdocs/FEATURE_MAP.md+docs/feature-map.html— catalog, request path, known gaps, inventory countsdocs/ARCHITECTURE.md—INSTALL_PERMISSIONSincludesapp.write/account.self;readscheck; role ceiling; Redis/MongoDBnoneauthdocs/CODE_MAP.md— wherereads,cappedRole,DATA_MIGRATE_MAX_OPS,wrapSqlForOrderedPage, and Redis keyspace livedocs/architecture/FEATURE-MODULE-GUIDE.md— new POST must declarereadsor a Demo account is refuseddocs/releases/UNRELEASED.md— release notes for the samedocs/plans/2026-10-17-data-compare-and-sql-tracer.md— status banner only (Parts 1 and 3 built; SQL Tracer not)Codepaths they cover
useCompareWindow→POST /api/sql/executewithorderBy→wrapSqlForOrderedPage(COMPARE_WINDOW_ROWS= 2,000, +1 probe)DATA_MIGRATE_ROW_CAPandPOST /api/data-migrate/executeshareDATA_MIGRATE_MAX_OPSauthGuard+requestAllowed+ routerreadsmarker; Demo role lacksapp.write/account.selfworkspaceRoleCeiling/cappedRole/memberRoleCeilingauthMethod: noneon Redis/MongoDB; Redis prefix vs collection tables inredis.keyspace.tsKnowledge gaps addressed
app.write/readsas open work (all shipped in feat(connections): Redis and MongoDB offer No password as a login method #557–feat(rbac): read-only is a permission; routes declare that they read #561)schema-force-migrate); the map no longer calls it missingreadsmarker (Demo accounts would 403)SQL Tracer remains unbuilt and stays on the gap list.
Note
Low Risk
Documentation-only changes with no runtime or API behavior modified in this diff.
Overview
This PR updates living documentation so it matches shipped behavior (#557–#561) instead of listing those items as open work or outdated limits.
User-facing and release notes (
user-guide.md,UNRELEASED.md) now describe Compare 2,000 rows (key-ordered window, in-memory filters/paging), data migrate capped at 2,000 ops (shared with the API), read-only viaapp.writeand the Demo role, personal-workspace role ceiling on invites/grants, and Redis keys as tables plus No password auth for Redis/MongoDB.Architecture and developer maps (
ARCHITECTURE.md,CODE_MAP.md,FEATURE-MODULE-GUIDE.md) document thereadsrouter marker for POSTs that only read,authGuard+requestAllowed,workspaceRoleCeiling/cappedRole, code locations (redis.keyspace.ts,wrapSqlForOrderedPage,DATA_MIGRATE_MAX_OPS), and a checklist item that new POSTs must declarereadsor Demo accounts get 403.Feature inventory (
FEATURE_MAP.md,feature-map.html) refreshes counts (155 routes, 56 e2e specs, ~600 unit tests), the request-path diagram (app.write or GET / reads before workspace scope), catalog rows for data compare / connections / workspaces, removes resolved gaps (compare 2,000, force-migrate e2e), and marks SQL Tracer as still unbuilt.Plan status (
2026-10-17-data-compare-and-sql-tracer.md) is updated: Parts 1 and 3 built; Part 2 (SQL Tracer) not.Reviewed by Cursor Bugbot for commit 1bd6b3b. Bugbot is set up for automated code reviews on this repo. Configure here.