Quad encoder#15
Conversation
rtyocum
left a comment
rtyocum
left a comment
There was a problem hiding this comment.
Most of it looks good, just a few small things.
|
|
||
| ESP_LOGI(TAG, "add limit watch points for count accumulation"); | ||
| int watch_points[] = {ENCODER_LOW_LIMIT, ENCODER_HIGH_LIMIT}; | ||
| for (size_t i = 0; i < sizeof(watch_points) / sizeof(watch_points[0]); i++) { |
There was a problem hiding this comment.
I don't think we need a loop for 2 watch points
There was a problem hiding this comment.
This was an artifact for the handy example code, it allows for more watch points in the future if needed.
| @@ -0,0 +1,56 @@ | |||
| menu "Encoder Configuration" | |||
There was a problem hiding this comment.
can we make this a config and pass it into the encoder? This module needs to be reusable, as we're gonna have a bunch of encoders and rn this only works for one it looks like. Also half of these aren't used other than in the tests. If thats the case move them to the test/Kconfig not here
I think pretty much every config in here should be passed in
There was a problem hiding this comment.
This seems to be resolved? If so close it
frey808
left a comment
frey808
left a comment
There was a problem hiding this comment.
looks good aside from what ryan pointed out
|
|
||
| ESP_LOGI(TAG, "add limit watch points for count accumulation"); | ||
| int watch_points[] = {ENCODER_LOW_LIMIT, ENCODER_HIGH_LIMIT}; | ||
| for (size_t i = 0; i < sizeof(watch_points) / sizeof(watch_points[0]); i++) { |
rtyocum
left a comment
rtyocum
left a comment
There was a problem hiding this comment.
works,and comments are resolved
3 participants
Description
Pulse counter library complete, tests pass. Accumulation works, axis 5 was manually spun past the signed 16bit value (32767) and the count just went straight past.
Metrics