ci: keep non-conventional commits in the changelog#42
Merged
Conversation
release-plz 0.3.159 inherits git-cliff filter_unconventional=true, which drops commits without a Conventional Commits prefix before the parsers run, so the catch-all never groups them. Setting filter_unconventional=false keeps the historical backlog (e.g. #31/#33) in "Other Changes". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
✅ PR title follows the Conventional Commits spec. |
takaebato
added a commit
that referenced
this pull request
Jun 28, 2026
## Problem PR #42 added `filter_unconventional = false` to `release-plz.toml`, but that key is **not supported by release-plz 0.3.159** (the latest release — it only exists in unreleased release-plz). Since #42 merged, the release-plz workflow on `master` now fails to parse the config: ``` unknown field `filter_unconventional`, expected one of `header`, `body`, `trim`, `commit_preprocessors`, `postprocessors`, `sort_commits`, `link_parsers`, `commit_parsers`, `protect_breaking_commits`, `tag_pattern` ``` ## Fix Remove the unsupported key, restoring a valid config so release-plz works again. ## Follow-up (separate) The original goal — including pre-convention (non-`type:`) commits like #31/#33 and the external #7/#9 in the changelog — has **no released config/upgrade fix** (the toggle is unreleased). It is a one-time historical-backlog gap; future commits are all conventional (PR-title lint). We'll handle that gap manually rather than via config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first Release PR (#41) silently dropped every commit that isn't a Conventional Commit — including major work like #31 (operator extraction) and #33 (the extraction-correctness pass), plus the external contributions #7/#9.
Root cause: the release-plz version that ran (0.3.159) inherits git-cliff's default
filter_unconventional = true, which discards non-conventional commits before thecommit_parsersrun — so the.*catch-all never sees them.Fix
Set
filter_unconventional = falseinrelease-plz.toml. Non-conventional commits are kept and routed to Other Changes via the catch-all.Effect
feat:prefix — recategorize by hand in the Release PR if desired.🤖 Generated with Claude Code