ci: remove unsupported filter_unconventional release-plz key#43
Merged
Conversation
filter_unconventional is not a valid release-plz.toml field in release-plz 0.3.159 (the latest release); it exists only in unreleased release-plz. PR #42 merged it and broke config parsing on master. This restores a valid config. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
✅ PR title follows the Conventional Commits spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #42 added
filter_unconventional = falsetorelease-plz.toml, but that key is not supported by release-plz 0.3.159 (the latest release — it only exists in unreleased release-plz). Since #42 merged, the release-plz workflow onmasternow fails to parse the config:Fix
Remove the unsupported key, restoring a valid config so release-plz works again.
Follow-up (separate)
The original goal — including pre-convention (non-
type:) commits like #31/#33 and the external #7/#9 in the changelog — has no released config/upgrade fix (the toggle is unreleased). It is a one-time historical-backlog gap; future commits are all conventional (PR-title lint). We'll handle that gap manually rather than via config.🤖 Generated with Claude Code