Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ updates:
- "typescript"
update-types: ["major"]

# The published npm wrapper. Effect is pinned to v4 RC -- effect@3 is a
# The published npm wrapper. Effect is on v4 -- effect@3 is a
# deliberate migration the wrapper never makes, so block a stray 3.x pin.
- package-ecosystem: npm
directory: "/npm/packages/comment-checker"
Expand All @@ -57,6 +57,9 @@ updates:
# typescript majors are deliberate migrations, not routine bumps.
- dependency-name: "typescript"
update-types: ["version-update:semver-major"]
# @types/node tracks the Node 24 LTS line; a newer major is a deliberate move.
- dependency-name: "@types/node"
update-types: ["version-update:semver-major"]

groups:
oxlint-minor-patch:
Expand Down Expand Up @@ -88,4 +91,5 @@ updates:
exclude-patterns:
- "oxlint"
- "typescript"
- "@types/node"
update-types: ["major"]
3 changes: 2 additions & 1 deletion .github/workflows/js-gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ jobs:
- name: Lint GitHub Actions workflows (issue #9)
run: ./scripts/tools/lint-workflows.ts

- name: Release scripts lint + matrix agreement (deno)
- name: Release scripts lint + matrix agreement + dependency pins (deno)
run: |
cd scripts
deno task lint
deno check --config ./deno.jsonc tools/*.ts
deno task check-matrix
deno task check-dep-pins
4 changes: 2 additions & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

A high-quality, mutation-tested Rust implementation of a Claude Code `PostToolUse` hook that classifies code comments as justified or unnecessary. SOTA engineering: 100% mutation on the core classifier, property-based tests, constitution-aligned, distributed via GitHub Releases and this repository's Nix flake.

The JS launcher layer uses Effect v4 RC. Never install, import, or pin `effect@3.*` in the JS side.
The JS launcher layer uses Effect v4. Never install, import, or pin `effect@3.*` in the JS side.

## Directory map

| Path | What it holds |
|------|---------------|
| `crates/` | Rust core (comment-checker crate) |
| `npm/packages/comment-checker/` | JS/npm wrapper (ESM + Effect v4 RC launcher for the Rust binary) |
| `npm/packages/comment-checker/` | JS/npm wrapper (ESM + Effect v4 launcher for the Rust binary) |
| `tests/` | Integration / F1 tests |
| `eval/` | Evaluation corpus |
| `.github/workflows/` | CI/release (pnpm + cross-platform Rust) |
Expand Down
6 changes: 3 additions & 3 deletions npm/packages/comment-checker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"lint": "f=${OXLINT_FORMAT:-${AGENT:+agent}}; oxlint . --format=${f:-default}"
},
"devDependencies": {
"@effect/platform-node": "4.0.0-rc.118",
"@types/node": "latest",
"effect": "4.0.0-rc.118",
"@effect/platform-node": "^4.0.2",
"@types/node": "^24.19.1",
"effect": "^4.0.2",
"oxlint": "latest",
"tsdown": "latest",
"typescript": "latest"
Expand Down
131 changes: 67 additions & 64 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ packages:
- 'npm/packages/*'
allowBuilds:
msgpackr-extract: false
overrides:
'@types/node': ^24.19.1
5 changes: 3 additions & 2 deletions scripts/deno.jsonc
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
{
"imports": {
"@effect/platform-deno": "npm:@effect/platform-deno@4.0.0-rc.118",
"@effect/platform-deno": "npm:@effect/platform-deno@4.0.2",
"@libs/diff": "jsr:@libs/diff@4.0.1",
"@std/cli": "jsr:@std/cli@1.0.32",
"@std/path": "jsr:@std/path@1.1.6",
"@std/toml": "jsr:@std/toml@1.0.11",
"@std/yaml": "jsr:@std/yaml@1.3.0",
"arktype": "npm:arktype@2.2.5",
"effect": "npm:effect@4.0.0-rc.118"
"effect": "npm:effect@4.0.2"
},
"tasks": {
"manifest:generate": "./tools/generate-platform-manifest.ts",
"check-matrix": "./tools/check-matrix.ts",
"check-dep-pins": "./tools/check-dep-pins.ts",
"lint": "deno lint --config ./deno.jsonc .",
"lint:workflows": "./tools/lint-workflows.ts"
},
Expand Down
Loading
Loading