Repository navigation
chore(deps): bump effect+platform-node to ^4.0.2, pin @types/node to 24 LTS - #134
Merged
Merged
Conversation
…24 LTS - effect, @effect/platform-node: 4.0.0-rc.118 -> ^4.0.2 (stable v4). - @types/node: latest -> ^24.19.1, tracking the Node 24 LTS line. - dependabot: ignore @types/node semver-major in the npm wrapper entry and exclude it from major-updates, mirroring the typescript handling, so the 24 pin is not re-bumped to 26.x. - pnpm-lock.yaml regenerated with pnpm@11.27.0. Supersedes #124, #125, #126, #127.
Review round on #134 (conductor ruling): - pnpm-workspace.yaml: overrides @types/node ^24.19.1, so @types/ws no longer resolves @types/node@26.6.4. pnpm 11 ignores package.json#pnpm ("The pnpm field in package.json is no longer read"), so the override lives next to allowBuilds. - scripts/tools/check-dep-pins.ts (deno task check-dep-pins), run in the js-gate.yml deno step: fails when any pnpm-lock.yaml resolution of @types/node is off the 24 line or none is resolved, and when the launcher dependabot entry stops ignoring typescript or @types/node semver-major. - scripts/deno.jsonc: effect and @effect/platform-deno 4.0.2, so the repo runs one Effect line. - dependabot.yml comment and AGENTS.md: Effect v4 RC -> Effect v4.
![kiro-systemf[bot]](https://avatars.githubusercontent.com/u/172220390?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Consolidated SOTA bump verified: effect+@effect/platform-node ^4.0.2, @types/node ^24.19.1 (Node 24 LTS) with a pnpm-workspace override collapsing the transitive 26.x copy, dependabot semver-major ignore for @types/node, and a new js-gate guard (check-dep-pins.ts) that reds CI if any @types/node leaves the 24 line (proven red on 26.x fixtures). deno.jsonc effect bump + AGENTS.md/dependabot.yml truth fixes. CI green (gate/nix/npm/packaging/tools); hunt-grep clean; base master. accept_eval=pass. Supersedes #124-127.
This was referenced Oct 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm launcher now bundles stable Effect 4.0.2 instead of 4.0.0-rc.118. Every
@types/nodein the lockfile is on the Node 24 LTS line, and CI fails if one leaves it. This replaces #124, #125, #126 and #127, which only reach 4.0.0/4.0.1 and float@types/nodeto 26.x.pnpm-workspace.yamloverride (@types/node: ^24.19.1) also covers the@types/wsedge that used to pull 26.6.4. pnpm 11 no longer readspackage.json#pnpm, so the override lives next toallowBuilds.deno task check-dep-pinsruns in the JS gate's deno step. It fails if any@types/nodeinpnpm-lock.yamlis off 24.x, if none is found at all, or if the launcher's Dependabot entry stops ignoringtypescriptor@types/nodesemver-major updates.scripts/deno.jsoncmoves to Effect 4.0.2 as well.latest, which moved root@effect/tsgofrom 0.48.1 to 0.51.1 (accepted).Checked locally: frozen install, build, typecheck, lint, the cargo gate, deno check/lint,
nix flake check, and theworkspace-tarballsrehearsal. The guard exits 1 on the master lockfile and on this PR's first lockfile (both carry@types/node@26.6.4), and exits 0 on this tree.