fix: revert jsdoc type cast support (for now) - #165
Merged
Conversation
Fixes #164; we'll follow up with a better solution
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/f3216a3a351a7d9dad197a3a5e8af63fc7ad203dOpen in |
🦋 Changeset detectedLatest commit: f3216a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Aug 14, 2026
elliott-with-the-longest-name-on-github
added a commit
that referenced
this pull request
Aug 17, 2026
…rs (#167) * Revert "fix: revert jsdoc type cast support (for now) (#165)" This reverts commit e51f38f. * fix: don't treat JSDoc @type comments on bindings as type casts Fixes #164 by tracking nodes in binding positions (variable declarator ids, function/method/arrow params, catch clause params) and excluding them from JSDoc type cast detection, so `let /** @type {T} */ x;` prints valid output while `/** @type {T} */ (expr)` casts keep their parentheses. * refactor: rename binding trackers and make them void for CQS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164; we'll follow up with a better solution